Merged
Conversation
Owner
|
It actually seems like I wonder if this issue the commenter referenced has been fixed on later versions of the IDE? |
Contributor
Author
|
AFAIK this this hadn't been fixed, but we can punt on this and test better later. |
Owner
I haven't been able to test personally, but I sent a binary to @fireyeti and he said the debug output said it was at 255.255.255.255 and was not accessible. I removed the commit and it is working normally for him. I didn't test it with only that line commented out. I'm currently using framework-arduinoespressif32 | framework | | ~3.10005.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #119