fix(ep): drain CXI FIFO rings before quiet - #8
Closed
fergusfinn wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to make nvshmemi_ibgda_quiet correctly fence/drain CXI D2H work that is sharded across multiple rings by posting (and waiting on) QUIET commands across all relevant D2H channels, instead of one ring per proxy thread.
Changes:
- Adds a CXI-specific stride/limit so QUIET can be posted on every D2H ring (vs. one per proxy).
- Tracks the exact D2H channel index for each posted QUIET so the wait phase targets the same rings that were posted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fergusfinn
force-pushed
the
pr997-quiet-all-rings
branch
from
June 17, 2026 16:36
e55ec6a to
eafa54a
Compare
This was referenced Jun 17, 2026
fergusfinn
force-pushed
the
pr997-quiet-all-rings
branch
from
June 17, 2026 17:03
eafa54a to
8d72efa
Compare
fergusfinn
force-pushed
the
pr997-quiet-all-rings
branch
3 times, most recently
from
June 17, 2026 17:49
e1d52eb to
41eb937
Compare
Post and wait QUIET across every D2H ring for the CXI path so sibling-ring work cannot remain queued behind a completed quiet. Cache the CXI transport selection when each proxy is constructed, and raise the 8-rank combine RDMA send chunk to satisfy the combine forwarder invariant when NUM_MAX_NVL_PEERS=4.
fergusfinn
force-pushed
the
pr997-quiet-all-rings
branch
from
June 17, 2026 20:03
41eb937 to
05a7d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing