[bug] [4.x] Hidden block types can still be added via the settings "cog" icon on existing blocks

[tomdavies]

Where Spoon has been configured to hide some Matrix blocks for a field layout, these hidden block types can still be added to the field still be via the settings "cog" icon on existing blocks:

The items in that list of matrix block types have a data-type="<blockHandle>" attribute on them, so it should be fairly easy to find that list and hide the block types that are not enabled for this field layout

LMK if you would accept a PR for this!

[tigerchick]

plus 1 for this.
This recently caused me a little trouble with a client adding blocks they weren't meant to be able to!

[tomdavies]

Having dug into this some more, there is code that should prevent this, but it never fires.

At the start of FieldManipulator::initSettingsMenu() we have:

Garnish.requestAnimationFrame($.proxy(function()
    {
    // Get the Garnish.MenuBtn object
    var menuBtn = $settingsBtn.data('menubtn') || false;
    
    // If there wasn’t one then fail and try again
    if (!menuBtn)
    {
        this.initSettingsMenu($settingsBtn, spoonedBlockTypes, $matrixField);
        return;
    }
...

The problem is $settingsBtn.data('menubtn') is always false. Guessing this is due to a change to the edit screen JS in Craft 4

[tomdavies]

Alright, I figured this out. The settings menu now uses Garnish.DisclosureMenu rather than the MenuBtn it used before. Fix is just a small JS change, PR inbound...

[tomdavies]

PRed 😄

CC @tigerchick in case you're in a hurry for a fix

[tigerchick]

PRed 😄

CC @tigerchick in case you're in a hurry for a fix

Thanks @tomdavies !

[lindseydiloreto]

PR has been merged, and the fix has been released in v4.0.2.

Thanks for all of your recent contributions @tomdavies! 🙏