Merged
Conversation
It's important for perf to override the base implementations, in particular for Read/WriteByte. I just copied the existing implementations to the new overrides and fixed up the implementations with as minimal changes as possible. I also tried to retain the style of the surrounding code. And none of the existing implementations have tests, so I didn't add any for these, as much as it pained me :)
This was referenced Sep 17, 2024
JanKrivanek
approved these changes
Sep 17, 2024
Contributor
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
Thank you!
Sorry about the tests :-(
I'll try fine some time to cover this
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's important for perf to override the base implementations, in particular for Read/WriteByte.
I just copied the existing implementations to the new overrides and fixed up the implementations with as minimal changes as possible. I also tried to retain the style of the surrounding code.
And none of the existing implementations have tests, so I didn't add any for these, as much as it pained me :)