feat(QueryPageOptions): remove obsolete parameters#7794
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves several obsolete, misspelled/aliased QueryPageOptions properties that simply forwarded to their modern counterparts, leaving the canonical properties as the only API surface for search/filter options and first-query detection. Class diagram for QueryPageOptions after removing obsolete propertiesclassDiagram
class QueryPageOptions_Before {
bool IsVirtualScroll
List~IFilterAction~ Searchs
List~IFilterAction~ Searches
List~IFilterAction~ CustomerSearchs
List~IFilterAction~ CustomerSearches
List~IFilterAction~ AdvanceSearchs
List~IFilterAction~ AdvanceSearches
List~IFilterAction~ Filters
bool IsFristQuery
bool IsFirstQuery
}
class QueryPageOptions_After {
bool IsVirtualScroll
List~IFilterAction~ Searches
List~IFilterAction~ CustomerSearches
List~IFilterAction~ AdvanceSearches
List~IFilterAction~ Filters
bool IsFirstQuery
}
QueryPageOptions_Before <|-- QueryPageOptions_After
class IFilterAction
QueryPageOptions_After "1" --> "*" IFilterAction
QueryPageOptions_Before "1" --> "*" IFilterAction
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Removing the obsolete alias properties (
Searchs,CustomerSearchs,AdvanceSearchs,IsFristQuery) is a breaking change for consumers, so consider confirming this aligns with your versioning policy or providing a migration note in the release notes/changelog.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Removing the obsolete alias properties (`Searchs`, `CustomerSearchs`, `AdvanceSearchs`, `IsFristQuery`) is a breaking change for consumers, so consider confirming this aligns with your versioning policy or providing a migration note in the release notes/changelog.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Pull request overview
This PR removes long-obsolete, misspelled compatibility properties from QueryPageOptions, leaving only the correctly named members and reducing public API surface area going forward.
Changes:
- Removed obsolete alias properties:
Searchs,CustomerSearchs,AdvanceSearchs - Removed obsolete misspelling alias property:
IsFristQuery
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7794 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 764 764
Lines 34109 34109
Branches 4697 4697
=========================================
Hits 34109 34109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7793
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: