Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideMoves the CSS custom property controlling the select/auto-complete append icon’s horizontal position into a shared variable and scopes its definition correctly so auto-complete append icons render in the right place. Flow diagram for CSS variable resolution for select/auto-complete append iconflowchart TD
A[$bb_select_append_right SCSS variable in variables_scss] --> B[Select_razor_scss .select and .auto_complete rule]
B --> C[Define CSS custom property --bb_select_append_right]
C --> D[Position append icon in select component]
C --> E[Position append icon in auto_complete component]
style A fill:#eef,stroke:#336
style B fill:#efe,stroke:#363
style C fill:#ffe,stroke:#663
style D fill:#f9f9ff,stroke:#333
style E fill:#f9f9ff,stroke:#333
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the clear button and dropdown icon in the AutoComplete component were appearing at the wrong location (at the start instead of the end of the input field). The issue was introduced in version 10.3.2 and is documented in issue #7716.
Changes:
- Added a new SCSS variable
$bb-select-append-right: 0to the global variables file - Moved the CSS variable
--bb-select-append-rightdefinition from the.selectselector to a combined.select, .auto-completeselector to ensure both components have access to it
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/BootstrapBlazor/wwwroot/scss/variables.scss | Added $bb-select-append-right: 0 SCSS variable to define the default right position for append icons |
| src/BootstrapBlazor/Components/Select/Select.razor.scss | Moved --bb-select-append-right CSS variable definition from .select scope to .select, .auto-complete combined scope to fix AutoComplete icon positioning |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7717 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 33207 33207
Branches 4604 4604
=========================================
Hits 33207 33207
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #7716
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: