Skip to content

fix(AutoComplete): append icon wrong place#7717

Merged
ArgoZhang merged 2 commits intomainfrom
fix-select
Feb 25, 2026
Merged

fix(AutoComplete): append icon wrong place#7717
ArgoZhang merged 2 commits intomainfrom
fix-select

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Feb 25, 2026

Link issues

fixes #7716

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Introduce a shared SCSS variable for the select/auto-complete append icon horizontal offset and apply it to both components.

Copilot AI review requested due to automatic review settings February 25, 2026 01:24
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Feb 25, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Moves the CSS custom property controlling the select/auto-complete append icon’s horizontal position into a shared variable and scopes its definition correctly so auto-complete append icons render in the right place.

Flow diagram for CSS variable resolution for select/auto-complete append icon

flowchart TD
    A[$bb_select_append_right SCSS variable in variables_scss] --> B[Select_razor_scss .select and .auto_complete rule]
    B --> C[Define CSS custom property --bb_select_append_right]
    C --> D[Position append icon in select component]
    C --> E[Position append icon in auto_complete component]
    style A fill:#eef,stroke:#336
    style B fill:#efe,stroke:#363
    style C fill:#ffe,stroke:#663
    style D fill:#f9f9ff,stroke:#333
    style E fill:#f9f9ff,stroke:#333
Loading

File-Level Changes

Change Details Files
Scope the CSS variable for the append icon offset to .select and .auto-complete instead of defining it globally on :root.
  • Remove the hard-coded --bb-select-append-right definition from the :root selector.
  • Define --bb-select-append-right within the .select and .auto-complete rule so it only affects those components.
  • Ensure the clear-icon and related positioned elements use the correctly scoped variable for layout.
src/BootstrapBlazor/Components/Select/Select.razor.scss
Introduce a SCSS variable for the append icon right offset and wire it into the component styles.
  • Add $bb-select-append-right SCSS variable with a default value of 0.
  • Expose this new SCSS variable as the CSS custom property --bb-select-append-right in the select/auto-complete styles so it can be themed or overridden consistently.
src/BootstrapBlazor/wwwroot/scss/variables.scss
src/BootstrapBlazor/Components/Select/Select.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#7716 Ensure the AutoComplete component's clear button and dropdown icon are rendered at the correct position (at the end/right side of the input field) instead of at the start, fixing the regression in v10.3.2.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Feb 25, 2026
@bb-auto bb-auto bot added this to the v10.3.0 milestone Feb 25, 2026
@ArgoZhang ArgoZhang merged commit da1ebaf into main Feb 25, 2026
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-select branch February 25, 2026 01:25
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bug where the clear button and dropdown icon in the AutoComplete component were appearing at the wrong location (at the start instead of the end of the input field). The issue was introduced in version 10.3.2 and is documented in issue #7716.

Changes:

  • Added a new SCSS variable $bb-select-append-right: 0 to the global variables file
  • Moved the CSS variable --bb-select-append-right definition from the .select selector to a combined .select, .auto-complete selector to ensure both components have access to it

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor/wwwroot/scss/variables.scss Added $bb-select-append-right: 0 SCSS variable to define the default right position for append icons
src/BootstrapBlazor/Components/Select/Select.razor.scss Moved --bb-select-append-right CSS variable definition from .select scope to .select, .auto-complete combined scope to fix AutoComplete icon positioning

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b58d252) to head (3f4e3ec).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7717   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        33207     33207           
  Branches      4604      4604           
=========================================
  Hits         33207     33207           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(AutoComplete): The icon and clear button are appearing in the wrong location

2 participants