feat(IContextMenuItem): add IsShow parameter#7608
Merged
Conversation
|
Thanks for your PR, @AiYuZhen. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Contributor
Reviewer's GuideImplements explicit ordering for context menu items and dividers, and adds an option to trim leading/trailing dividers from rendered context menus, with accompanying unit tests. Sequence diagram for rendering ordered and trimmed context menusequenceDiagram
actor User
participant Browser
participant ContextMenu
User->>Browser: Right click target
Browser->>ContextMenu: Render context menu
ContextMenu->>ContextMenu: GetContextMenuItems()
activate ContextMenu
ContextMenu->>ContextMenu: Sort _contextMenuItems by Order
alt TrimStartAndEndDivider enabled
ContextMenu->>ContextMenu: Remove leading ContextMenuDivider items
ContextMenu->>ContextMenu: Remove trailing ContextMenuDivider items
end
ContextMenu-->>Browser: Ordered and trimmed items
deactivate ContextMenu
Browser-->>User: Display context menu
Class diagram for ordered and trimmed context menu itemsclassDiagram
class ContextMenu {
+RenderFragment ChildContent
+bool TrimStartAndEndDivider
-List~IContextMenuItem~ _contextMenuItems
-List~IContextMenuItem~ GetContextMenuItems()
}
class IContextMenuItem {
+int Order
}
class ContextMenuItem {
+string Text
+int Order
}
class ContextMenuDivider {
+int Order
}
ContextMenuItem ..|> IContextMenuItem
ContextMenuDivider ..|> IContextMenuItem
ContextMenu o--> IContextMenuItem
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7608 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 33003 33005 +2
Branches 4580 4580
=========================================
+ Hits 33003 33005 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This reverts commit df336ea.
ArgoZhang
previously approved these changes
Jan 31, 2026
This was referenced Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
增加上下文菜单项反排序。
增加 TrimStartAndEndDivider 参数,确保开始及结尾菜单项不是分割线。
Link issues
fixes #7605
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add configurable trimming of leading and trailing dividers and support ordered rendering for context menu items.
New Features:
Tests: