feat(PdfViewer): add ShowToolbar parameter #7594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a configurable ShowToolbar parameter to the PdfViewer sample and wires it to a new UI switch, while adjusting the sample PDF URL and component backing state to support toolbar visibility toggling. Sequence diagram for toggling PdfViewer ShowToolbar parametersequenceDiagram
actor User
participant Browser
participant PdfViewersComponent
participant PdfViewer
User->>Browser: Toggle ShowToolbar switch
Browser->>PdfViewersComponent: Update _showToolbar via binding
PdfViewersComponent->>PdfViewer: Render with ShowToolbar = _showToolbar and updated Url
PdfViewer-->>User: Display PDF with toolbar visibility applied
Updated class diagram for PdfViewers sample component backing classclassDiagram
class PdfViewers {
int _pageIndex
bool _showToolbar
Task OnLoaded()
Task NotSupportCallback()
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In the sample, the URL is hard-coded with
#toolbar=0&navpanes=0whileShowToolbaris bound to_showToolbar; consider aligning these so the newShowToolbarparameter is the single source of truth for toolbar visibility to avoid confusing or conflicting behavior.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In the sample, the URL is hard-coded with `#toolbar=0&navpanes=0` while `ShowToolbar` is bound to `_showToolbar`; consider aligning these so the new `ShowToolbar` parameter is the single source of truth for toolbar visibility to avoid confusing or conflicting behavior.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7594 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32988 32988
Branches 4578 4578
=========================================
Hits 32988 32988
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the server demo to expose the new ShowToolbar option for PdfViewer and bumps the BootstrapBlazor.PdfViewer package version to a release that includes the parameter.
Changes:
- Add
_showToolbarstate and a UI switch to toggle toolbar visibility in the PdfViewer sample. - Pass the new
ShowToolbarparameter to<PdfViewer />in the sample. - Update
BootstrapBlazor.PdfViewerpackage reference from10.0.0to10.0.1.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/PdfViewers.razor.cs | Adds backing field to support toolbar toggle in the sample. |
| src/BootstrapBlazor.Server/Components/Samples/PdfViewers.razor | Adds a switch and wires ShowToolbar into the PdfViewer demo. |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Bumps PdfViewer package to pick up the new parameter. |
Comments suppressed due to low confidence (1)
src/BootstrapBlazor.Server/Components/Samples/PdfViewers.razor.cs:16
- Field '_useGoogleDocs' can be 'readonly'.
private bool _useGoogleDocs = false;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </section> | ||
| <PdfViewer Url="./samples/sample.pdf" Height="620px" PageIndex="@_pageIndex" | ||
| NotSupportCallback="NotSupportCallback" OnLoaded="OnLoaded" | ||
| <PdfViewer Url="./samples/sample.pdf#toolbar=0&navpanes=0" Height="620px" PageIndex="@_pageIndex" |
There was a problem hiding this comment.
Url is now hardcoded with #toolbar=0&navpanes=0, which will force the browser PDF plugin to hide the toolbar regardless of the new ShowToolbar parameter. This makes the toggle ineffective and can also conflict with PdfViewer’s own URL handling. Consider keeping Url as the raw PDF path and let ShowToolbar control toolbar visibility (or dynamically append/remove the fragment based on _showToolbar).
Suggested change
| <PdfViewer Url="./samples/sample.pdf#toolbar=0&navpanes=0" Height="620px" PageIndex="@_pageIndex" | |
| <PdfViewer Url="./samples/sample.pdf" Height="620px" PageIndex="@_pageIndex" |
|
|
||
| private int _pageIndex = 1; | ||
|
|
||
| private bool _showToolbar = true; |
There was a problem hiding this comment.
Field '_showToolbar' can be 'readonly'.
Suggested change
| private bool _showToolbar = true; | |
| private readonly bool _showToolbar = true; |
| @@ -17,6 +17,8 @@ public partial class PdfViewers | |||
|
|
|||
| private int _pageIndex = 1; | |||
There was a problem hiding this comment.
Field '_pageIndex' can be 'readonly'.
Suggested change
| private int _pageIndex = 1; | |
| private readonly int _pageIndex = 1; |
This was referenced Jan 30, 2026
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7588
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add configurable toolbar visibility to the PDF viewer sample component.
New Features:
Enhancements: