Skip to content

Put generated InvalidClientHelloDataTruncatedBytes data into one test #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2021
Merged

Put generated InvalidClientHelloDataTruncatedBytes data into one test #1432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions test/ReverseProxy.Tests/Utilities/TlsFrameHelperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,14 @@ public void SniHelper_InvalidData_Fails(int id, byte[] clientHello)
InvalidClientHello(clientHello, id, shouldPass: false);
}

[Theory]
[MemberData(nameof(InvalidClientHelloDataTruncatedBytes))]
public void SniHelper_TruncatedData_Fails(int id, byte[] clientHello)
[Fact]
public void SniHelper_TruncatedData_Fails()
{
InvalidClientHello(clientHello, id, shouldPass: false);
// moving inside one test because there are more than 3000 cases and they overflow subresults
foreach ((int id, byte[] clientHello) in InvalidClientHelloDataTruncatedBytes())
{
InvalidClientHello(clientHello, id, shouldPass: false);
}
}

private void InvalidClientHello(byte[] clientHello, int id, bool shouldPass)
Expand Down Expand Up @@ -129,7 +132,7 @@ public static IEnumerable<object[]> InvalidClientHelloData()
}
}

public static IEnumerable<object[]> InvalidClientHelloDataTruncatedBytes()
public static IEnumerable<Tuple<int, byte[]>> InvalidClientHelloDataTruncatedBytes()
{
// converting to base64 first to remove duplicated test cases
var uniqueInvalidHellos = new HashSet<string>();
Expand All @@ -150,7 +153,7 @@ public static IEnumerable<object[]> InvalidClientHelloDataTruncatedBytes()
foreach (string invalidClientHello in uniqueInvalidHellos)
{
id++;
yield return new object[] { id, Convert.FromBase64String(invalidClientHello) };
yield return new Tuple<int, byte[]>(id, Convert.FromBase64String(invalidClientHello));
}
}

Expand Down