Skip to content

Fix KeyNotFoundException when simulator lacks runtimeIdentifier or version #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simonrozsival merged 9 commits into from
Nov 25, 2025
Merged

Fix KeyNotFoundException when simulator lacks runtimeIdentifier or version #1501

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ec4450
Initial plan
Copilot Nov 19, 2025
267167a
Fix SimulatorsCommand to skip entries without runtimeIdentifier and a…
Copilot Nov 19, 2025
de9abb5
Completed fix for SimulatorsCommand runtimeIdentifier issue
Copilot Nov 19, 2025
4454559
Remove accidentally committed nuget.exe
Copilot Nov 19, 2025
dc4f0d9
Address review feedback: check version property and improve tests
Copilot Nov 19, 2025
bd2e30c
Fix KeyNotFoundException when simulator lacks runtimeIdentifier or ve…
Copilot Nov 19, 2025
b55c26a
Remove SimulatorsCommandTests as requested
Copilot Nov 19, 2025
f37a3e0
Remove nuget.exe and add to .gitignore
Copilot Nov 19, 2025
f7c5202
Remove unnecessary changes from gitignore
simonrozsival Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ PublishScripts/
*.nuget.props
*.nuget.targets

# NuGet executable
Comment thread
simonrozsival marked this conversation as resolved.
Outdated
.nuget/nuget.exe
Comment thread
simonrozsival marked this conversation as resolved.
Outdated

Comment thread
simonrozsival marked this conversation as resolved.
Outdated
# Microsoft Azure Build Output
csx/
*.build.csdef
Expand Down
16 changes: 14 additions & 2 deletions src/Microsoft.DotNet.XHarness.CLI/Commands/Apple/Simulators/SimulatorsCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,9 +238,21 @@ protected async Task<IEnumerable<Simulator>> GetAvailableSimulators()

foreach (JsonProperty sim in simulators.RootElement.EnumerateObject())
{
if (sim.Value.GetProperty("runtimeIdentifier").GetString() == runtimeIdentifier)
// Skip entries that don't have a runtimeIdentifier property (e.g., unusable simulators)
if (!sim.Value.TryGetProperty("runtimeIdentifier", out var runtimeIdProperty))
{
var version = sim.Value.GetProperty("version").GetString();
continue;
}

if (runtimeIdProperty.GetString() == runtimeIdentifier)
{
// Also check if version property exists
if (!sim.Value.TryGetProperty("version", out var versionProperty))
{
return null;
}

var version = versionProperty.GetString();
if (version == null)
return null;

Expand Down