Remove firewall setting from copilot-setup-steps.yml #1430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually work as an env var, it needs to be set as a GitHub Actions variable in the repository settings.
…or doesn't break Copilot
3 tasks
kotlarmilos
approved these changes
Jun 30, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unsupported firewall environment variable from the GitHub Actions workflow and updates the build step to only perform a restore, as outlined in the PR description.
- Removed the COPILOT_AGENT_FIREWALL_ALLOW_LIST_ADDITIONS env variable block
- Updated the build step to use "./eng/common/build.sh --restore" for dependency restoration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't actually work as an env var, it needs to be set as a GitHub Actions variable in the repository settings: https://github.com/orgs/community/discussions/163374
I added the variable and it seems to have helped Copilot access the feeds.
Also only do a restore in copilot-setup-steps.yml to make sure a build error doesn't break Copilot