Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address CS0656 with latest compiler #9135

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented May 20, 2024

The latest compiler fails to build WPF with

CSC : error CS0656: Missing compiler required member 'System.Runtime.InteropServices.MemoryMarshal.CreateReadOnlySpan' [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\System.Windows.Input.Manipulations\System.Windows.Input.Manipulations.csproj]
CSC : error CS0656: Missing compiler required member 'System.Runtime.InteropServices.MemoryMarshal.CreateReadOnlySpan' [D:\a\_work\1\vmr\src\wpf\src\Microsoft.DotNet.Wpf\src\UIAutomation\UIAutomationTypes\UIAutomationTypes.csproj]

Adding a reference to System.Memory to avoid this. I believe this is due to use of collection expressions taking advantage of this API

Microsoft Reviewers: Open in CodeFlow

@ericstj ericstj requested a review from a team as a code owner May 20, 2024 21:07
@dotnet-policy-service dotnet-policy-service bot added the PR metadata: Label to tag PRs, to facilitate with triage label May 20, 2024
@ericstj ericstj requested review from 333fred and jozkee May 20, 2024 21:47
@ericstj ericstj merged commit d6b1f45 into main May 20, 2024
8 checks passed
@ericstj ericstj deleted the ericstj-system-memory-CS0656 branch May 20, 2024 21:50
@ericstj
Copy link
Member Author

ericstj commented May 21, 2024

Looks like we need more than this. It's also failing in UIAutomationProvider. Will see about reproducing in a WPF build to make sure we get everything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants