Fix build when using source generators coming from NuGet packages. #6793
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested review from
|
@dotnet/wpf-developers: This should probably be considered to be backported to .Net 6.0. |
|
This is just to confirm that this patch will also fix the problems we're having with WPF class libraries in tandem with Refit. |
AliveDevil
added a commit
to iterate-ch/cyberduck
that referenced
this pull request
Jul 14, 2022
AliveDevil
added a commit
to iterate-ch/cyberduck
that referenced
this pull request
Jul 14, 2022
dipeshmsft
approved these changes
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6792
Description
Fixes build of project using source generators coming from NuGet packages. I fixed this by only including analyzers that are coming from a FrameworkReference in the temporary target assembly project. Those analyzers are the ones that are not automatically added in the temporary target assembly project because
ResolveTargetingPackAssetsis never called (We could investigate calling this target in the future but, to me, it seemed riskier than the changes in this PR).Customer Impact
Fixes build.
Regression
This is a regression introduced in .Net 6.0.7 by #6534 which was backported by #6680. Those were changes from me, sorry about the regression.
Testing
Tested locally by building a project which uses Regex source generator, WinForms source generator and CommunityToolkit.Mvvm 7.1.2 source generator (This is an example of a source generator that currently fails on .Net 6.0.7 SDK).
Risk
Low.