Draft: Performance improvement for UIElement.Arrange and UIElement.Measure #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
requested review from
deeprobin
commented
Nov 23, 2021
deeprobin
commented
Nov 23, 2021
src/Microsoft.DotNet.Wpf/src/WindowsBase/System/Windows/DependencyObject.cs
Show resolved
Hide resolved
deeprobin
commented
Nov 23, 2021
deeprobin
commented
Nov 23, 2021
|
|
||
| _firePostLayoutEvents = true; | ||
| } | ||
|
|
||
| [MethodImpl(MethodImplOptions.NoInlining)] | ||
| [DoesNotReturn] | ||
| private static void ThrowInvalidOperationForDeepRecursion() |
There was a problem hiding this comment.
Move into ThrowHelper.cs
|
Reference: #6219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will not fix the issue #4768 completely but may improve the performance already
Description
I tried to replace some heap allocations with stack "allocations" using
Span<T>andReadOnlySpan<T>A bottleneck is unfortunately in the non-open-source PresentationNative part (
LoCreateLine), on which I can unfortunately not influenceTesting
(todo)
Benchmarks
(todo)
Risk