[release/6.0-rc1] Update dependencies from dotnet/winforms #5208

dotnet-maestro · 2021-08-28T03:40:23Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- System.CodeDom: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Diagnostics.EventLog: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.DirectoryServices: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Drawing.Common: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Security.Cryptography.Xml: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Security.Permissions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Windows.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.IO.Packaging: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- System.Resources.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms)

From https://github.com/dotnet/winforms

Subscription: ccecb758-30c2-4b74-af81-08d961c59698
Build: 20210830.13
Date Produced: 8/30/2021 6:57 PM
Commit: bab479fa2de8644d36533ef8c35022ff4d6e0c13
Branch: refs/heads/release/6.0-rc1

Updates:
- Microsoft.Dotnet.WinForms.ProjectTemplates: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21430.13
- Microsoft.Private.Winforms: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21430.13
- System.CodeDom: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Configuration.ConfigurationManager: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Diagnostics.EventLog: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.DirectoryServices: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Drawing.Common: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Reflection.MetadataLoadContext: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Security.Cryptography.Xml: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Security.Permissions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Windows.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- Microsoft.NETCore.Platforms: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.IO.Packaging: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- Microsoft.NETCore.ILDAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- Microsoft.NETCore.ILAsm: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- System.Resources.Extensions: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11
- VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.1.21426.17 to 6.0.0-rc.1.21430.11

…10827.24 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21427.24 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.1.21426.17 -> To Version 6.0.0-rc.1.21427.30 (parent: Microsoft.Private.Winforms

…10830.5 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21430.5 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.1.21426.17 -> To Version 6.0.0-rc.1.21430.1 (parent: Microsoft.Private.Winforms

…10830.7 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21430.7 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.1.21426.17 -> To Version 6.0.0-rc.1.21430.5 (parent: Microsoft.Private.Winforms

mmitche · 2021-08-30T15:44:28Z

@ryalanms This looks a bit interesting.

…10830.13 Microsoft.Dotnet.WinForms.ProjectTemplates , Microsoft.Private.Winforms From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21430.13 Dependency coherency updates System.CodeDom,System.Configuration.ConfigurationManager,System.Diagnostics.EventLog,System.DirectoryServices,System.Drawing.Common,System.Reflection.MetadataLoadContext,System.Security.Cryptography.Xml,System.Security.Permissions,System.Windows.Extensions,Microsoft.NETCore.Platforms,System.IO.Packaging,Microsoft.NETCore.ILDAsm,Microsoft.NETCore.ILAsm,System.Resources.Extensions,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,VS.Redist.Common.NetCore.SharedFramework.x64.6.0 From Version 6.0.0-rc.1.21426.17 -> To Version 6.0.0-rc.1.21430.11 (parent: Microsoft.Private.Winforms

mmitche · 2021-08-30T19:26:15Z

@ericstj @eerhardt This failure looks pretty interesting, can you take a peek?

eerhardt · 2021-08-30T19:28:57Z

This is due to my change dotnet/runtime#58278 to support incremental Roslyn source generators. To fix it, we need to use VS 2022. Using VS 2019 uses the old Roslyn version, which gives this error.

ericstj · 2021-08-30T19:30:07Z

We can just remove the analyzers to unblock this build, do a new version of 1400177. I suspect that it's harder to update compiler here (though not certain) since I think WPF builds using desktop MSBuild which requires VS installed on the build agents.

ryalanms · 2021-08-30T20:03:57Z

I see here that there is now a 2022 build queue: https://github.com/dotnet/core-eng/wiki/VS2022-Upgrade-Schedule.

Should WPF move to this queue now?

BuildPool.Windows.Amd64.VS2022.Pre.Open

These require VS 2022 Roslyn v4.0, but the CI machine is still using VS 2019.

ericstj · 2021-08-30T20:24:59Z

Directory.Build.targets

+       https://github.com/dotnet/wpf/issues/5224 -->
+  <Target Name="_RemoveFrameworkReferenceAnalyzers" AfterTargets="ResolveTargetingPackAssets">
+    <ItemGroup>
+      <Analyzer Remove="@(Analyzer)" Condition="'%(Analyzer.FrameworkReferenceName)' != '' and $([System.String]::Copy('%(Directory)').IndexOf('analyzers', StringComparison.OrdinalIgnoreCase)) > 0" />


Suggested change

<Analyzer Remove="@(Analyzer)" Condition="'%(Analyzer.FrameworkReferenceName)' != '' and $([System.String]::Copy('%(Directory)').IndexOf('analyzers', StringComparison.OrdinalIgnoreCase)) > 0" />

<Analyzer Remove="@(Analyzer)" Condition="'%(Analyzer.FrameworkReferenceName)' != ''" />

You can remove the later part of this condition. That was present when I needed to distingush analyzers from refs (WPF was previously using an SDK which raised them as references).

Waiting for CI to validate the current changes and then will commit this suggestion.

Or not, I guess

mmitche · 2021-08-31T16:57:43Z

@ryalanms We will need to move to the vs2022 queue eventually I think, or alter the repo logic at https://github.com/dotnet/wpf/blob/main/eng/WpfArcadeSdk/Sdk/Sdk.props#L18. When we flip to RTM, the VS2019 queue won't be able to supply langversion:10. I am not sure whether it's right to keep it at preview for the rtm build.

/cc @MattGal if you have any thoughts on this.

MattGal · 2021-08-31T17:01:49Z

/cc @MattGal if you have any thoughts on this.

Just two primarily:

Right now, due to the activation issues, we only have .Open VS 2022 machines in dnceng/public. If we need official build machines, we should create an issue to handle this on the dotnet/core-eng repo.
We should probably use a VS 2022 buildtools SKU to prevent time-bombing since this is purely for build.

If we're certain we need the internal build agents, let me know and I'll get an FR issue on the board.

mmitche · 2021-08-31T17:04:25Z

@MattGal I'll leave the WPF folks to comment on whether it's required. If langversion 10 is required (and we can't use preview to get it for the rtm build), then we'll need internal build queues.

My hunch, though, is that we could keep it preview for the rtm build and flip to 10 after dev17 ships.

ryalanms · 2021-09-03T20:43:28Z

@eerhardt: I believe we need this change in release/6.0 and main as well: 280cdc6.

eerhardt · 2021-09-03T20:57:36Z

@ryalanms - I've updated both:

[release/6.0] Update dependencies from dotnet/winforms #5223 (release/6.0)
[main] Update dependencies from dotnet/winforms #5212 (main)

[release/6.0] Update dependencies from dotnet/winforms - Coherency Updates: - System.CodeDom: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Configuration.ConfigurationManager: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Diagnostics.EventLog: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.DirectoryServices: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Drawing.Common: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Reflection.MetadataLoadContext: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Security.Cryptography.Xml: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Security.Permissions: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Windows.Extensions: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.Platforms: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.IO.Packaging: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.ILDAsm: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.ILAsm: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - System.Resources.Extensions: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.App.Ref: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-rc.2.21429.8 to 6.0.0-rc.2.21453.6 (parent: Microsoft.Private.Winforms) - Remove Analyzers coming from net6.0 ref pack These require VS 2022 Roslyn v4.0, but the CI machine is still using VS 2019. - Respond to PR feedback from #5208 (#5225)

ryalanms · 2021-09-03T21:10:52Z

Thank you!

[main] Update dependencies from dotnet/winforms - Coherency Updates: - System.CodeDom: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Configuration.ConfigurationManager: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Diagnostics.EventLog: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.DirectoryServices: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Drawing.Common: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Reflection.MetadataLoadContext: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Security.Cryptography.Xml: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Security.Permissions: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Windows.Extensions: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.Platforms: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.IO.Packaging: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.ILDAsm: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.ILAsm: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - System.Resources.Extensions: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.App.Ref: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-alpha.1.21427.1 to 7.0.0-alpha.1.21453.1 (parent: Microsoft.Private.Winforms) - Merge branch 'main' into darc-main-6135067d-e034-47ce-af6b-28e16f5b1dd6 - Remove Analyzers coming from net6.0 ref pack These require VS 2022 Roslyn v4.0, but the CI machine is still using VS 2019. - Respond to PR feedback from #5208 (#5225)

dotnet-maestro bot requested a review from a team as a code owner August 28, 2021 03:40

ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Aug 28, 2021

ghost requested review from fabiant3, ryalanms and SamBent August 28, 2021 03:40

dotnet-maestro bot added 2 commits August 30, 2021 12:29

eerhardt mentioned this pull request Aug 30, 2021

Use Roslyn v4.0 to build net6.0 #5224

Closed

Remove Analyzers coming from net6.0 ref pack

280cdc6

These require VS 2022 Roslyn v4.0, but the CI machine is still using VS 2019.

ericstj reviewed Aug 30, 2021

View reviewed changes

dotnet-maestro bot merged commit 8fa13be into release/6.0-rc1 Aug 30, 2021

dotnet-maestro bot deleted the darc-release/6.0-rc1-e267fd0a-f5d0-47b6-81a0-612dfa37f09e branch August 30, 2021 20:37

eerhardt added a commit that referenced this pull request Aug 30, 2021

Respond to PR feedback from #5208

5c1013a

eerhardt mentioned this pull request Aug 30, 2021

Respond to PR feedback #5225

Merged

mmitche pushed a commit that referenced this pull request Aug 30, 2021

Respond to PR feedback from #5208 (#5225)

d26acd0

ryalanms mentioned this pull request Sep 2, 2021

[release/6.0] Update dependencies from dotnet/winforms #5223

Merged

eerhardt added a commit that referenced this pull request Sep 3, 2021

Respond to PR feedback from #5208 (#5225)

a3a9a5d

eerhardt added a commit that referenced this pull request Sep 3, 2021

Respond to PR feedback from #5208 (#5225)

70cfe53

eerhardt mentioned this pull request Sep 8, 2021

[main] Update dependencies from dotnet/arcade dotnet/aspnetcore dotnet/razor#4175

Merged

ghost locked as resolved and limited conversation to collaborators Apr 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/6.0-rc1] Update dependencies from dotnet/winforms #5208

[release/6.0-rc1] Update dependencies from dotnet/winforms #5208

dotnet-maestro bot commented Aug 28, 2021 •

edited

Loading

mmitche commented Aug 30, 2021

mmitche commented Aug 30, 2021

eerhardt commented Aug 30, 2021

ericstj commented Aug 30, 2021 •

edited

Loading

ryalanms commented Aug 30, 2021

ericstj Aug 30, 2021

eerhardt Aug 30, 2021

eerhardt Aug 30, 2021

mmitche commented Aug 31, 2021

MattGal commented Aug 31, 2021

mmitche commented Aug 31, 2021

ryalanms commented Sep 3, 2021

eerhardt commented Sep 3, 2021

ryalanms commented Sep 3, 2021

	<Analyzer Remove="@(Analyzer)" Condition="'%(Analyzer.FrameworkReferenceName)' != '' and $([System.String]::Copy('%(Directory)').IndexOf('analyzers', StringComparison.OrdinalIgnoreCase)) > 0" />
	<Analyzer Remove="@(Analyzer)" Condition="'%(Analyzer.FrameworkReferenceName)' != ''" />

[release/6.0-rc1] Update dependencies from dotnet/winforms #5208

[release/6.0-rc1] Update dependencies from dotnet/winforms #5208

Conversation

dotnet-maestro bot commented Aug 28, 2021 • edited Loading

Coherency Updates

From https://github.com/dotnet/winforms

mmitche commented Aug 30, 2021

mmitche commented Aug 30, 2021

eerhardt commented Aug 30, 2021

ericstj commented Aug 30, 2021 • edited Loading

ryalanms commented Aug 30, 2021

ericstj Aug 30, 2021

Choose a reason for hiding this comment

eerhardt Aug 30, 2021

Choose a reason for hiding this comment

eerhardt Aug 30, 2021

Choose a reason for hiding this comment

mmitche commented Aug 31, 2021

MattGal commented Aug 31, 2021

mmitche commented Aug 31, 2021

ryalanms commented Sep 3, 2021

eerhardt commented Sep 3, 2021

ryalanms commented Sep 3, 2021

dotnet-maestro bot commented Aug 28, 2021 •

edited

Loading

ericstj commented Aug 30, 2021 •

edited

Loading