Enable nullability in DesignerFrame and clean it up #9966
Conversation
|
LGTM！ |
| ISelectionService selSvc = (ISelectionService)_designerSite.GetService(typeof(ISelectionService)); | ||
| if (selSvc is not null) | ||
| ISelectionService? selSvc = _designerSite.GetService<ISelectionService>(); | ||
| if (selSvc?.PrimarySelection is Control { IsDisposed: false } ctrl) |
There was a problem hiding this comment.
we need consistency in adapting this syntax standard. Will get this reviewed collectively and make decision across the PRs.
There was a problem hiding this comment.
I'm happy to rollback such changes if it's a contentious issue. Here it doesn't add much to the table anyway.
There was a problem hiding this comment.
Not yet. Will update here if needed. We just need consistency in adapting these.
There was a problem hiding this comment.
We are preferring pattern matching wherever possible. While we do not expect or encourage community to do a pass specifically for the pattern matching on the existing code, if you happen to be working on the code as part of some other fix, identify an opportunity to incorporate pattern matching, we take it.
lonitra
added
the
waiting-on-team
dreddy-work
removed
the
waiting-on-team
ghost
locked as resolved and limited conversation to collaborators
Proposed changes
ArrayLists withList<T>s inDesignerFrame(contributes to ConvertArrayListusage toList<T>where possible #8140)DesignerFrameDesignerFrameand one call siteMicrosoft Reviewers: Open in CodeFlow