Skip to content

Conversation

@MattGal
Copy link
Member

@MattGal MattGal commented Feb 3, 2023

Ready to merge. This change opts in to automatic pool provider selection and demonstrates how we can correctly separate servicing ("anything in a release branch") builds from main / dev branch builds.

I have validated all the existing winforms pipelines I touched using my changes, as described below.

Testing azure-pipelines.yml: This PR

Testing eng\pipelines\azure-pipelines-codeql.yml:
https://dnceng.visualstudio.com/internal/_build/results?buildId=2106174&view=logs&j=eb2c8817-e906-5459-8080-1a4c8ed1e2e2

Testing azure-pipelines-richnav.yml:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=161654&view=logs&j=0bc77094-9fcd-5c38-f6e4-27d2ae131589&t=2ff0d05b-859b-4800-af69-e3b925e8874d

Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned MattGal Feb 3, 2023
@ghost ghost added the draft draft PR label Feb 4, 2023
@Tanya-Solyanik Tanya-Solyanik added the 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) label Feb 4, 2023
…umb through usage of /eng/common/templates/variables/pool-providers.yml
@MattGal MattGal force-pushed the automatic-pool-provider-selection branch from 315e49e to 462c11b Compare February 6, 2023 21:50
@MattGal MattGal marked this pull request as ready for review February 6, 2023 21:52
@MattGal MattGal requested a review from a team as a code owner February 6, 2023 21:52
@MattGal MattGal removed 🚫 * NO-MERGE * The PR is not ready for merge yet (see discussion for detailed reasons) draft draft PR labels Feb 6, 2023
@Tanya-Solyanik Tanya-Solyanik enabled auto-merge (squash) February 6, 2023 22:32
@Tanya-Solyanik Tanya-Solyanik merged commit 3027d91 into dotnet:release/8.0-preview1 Feb 6, 2023
MattGal added a commit to MattGal/winforms that referenced this pull request Feb 6, 2023
Tanya-Solyanik pushed a commit that referenced this pull request Feb 7, 2023
Cherry pick of release/8 branch of "Automatic pool provider selection (#8564)"
@ghost ghost locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants