Refactor WebBrowserContainer to replace HashTable and Enable Nullability #8226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
reviewed
Nov 18, 2022
src/System.Windows.Forms/src/System/Windows/Forms/WebBrowserContainer.cs
Show resolved
Hide resolved
dreddy-work
reviewed
Nov 18, 2022
| string name = (ctl.Site is not null) ? ctl.Site.Name : ctl.Name; | ||
| return name ?? ""; | ||
| } | ||
| => ctl.Site is not null ? ctl.Site.Name ?? string.Empty : ctl.Name; |
There was a problem hiding this comment.
This just condenses the existing logic. ctl.Name is only used when ctl.Site is null. Otherwise ctl.Site.Name is used and that can be null, so it returns string.Empy in that case.
There was a problem hiding this comment.
right, earlier, we never return null. now we may be.
There was a problem hiding this comment.
I've updated it to check if ctl.Name is null and return string.empty. That should handle it.
dreddy-work
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
dreddy-work
added
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored WebBrowserContainer to replace HashTable and Enable Nullability.
Related to #8143
Microsoft Reviewers: Open in CodeFlow