Refactor ComponentDesigner to use Dictionary<TKey, TValue> instead of Hashtable #8221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreddy-work
reviewed
Nov 17, 2022
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/ComponentDesigner.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
|
@dreddy-work flaky test? |
Seems test aborted or crashed on arm. Resetting it for now. |
|
@dreddy-work you didn't approve the PR and it's set to auto-merge. |
dreddy-work
approved these changes
Nov 18, 2022
yah. forgot. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8143
Microsoft Reviewers: Open in CodeFlow