Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ArrangedElementCollection to replace ArrayList #8202

Closed

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Nov 15, 2022

Related: #8140

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner November 15, 2022 22:56
@ghost ghost assigned elachlan Nov 15, 2022
@@ -127,19 +127,28 @@ private static void Copy(ArrangedElementCollection sourceList, int sourceIndex,

void IList.Clear() => InnerList.Clear();

bool IList.IsFixedSize => InnerList.IsFixedSize;
bool IList.IsFixedSize => false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property is causing issues as classes that inherit from this can't see it. The compiler complains when I try changing it.

@Jericho
Copy link
Contributor

Jericho commented Nov 16, 2022

@elachlan I didn't notice you submitted this PR and I submitted similar PR: #8207.

Sorry for the duplicate effort.

@elachlan
Copy link
Contributor Author

No problem.

@elachlan elachlan closed this Nov 16, 2022
@elachlan elachlan deleted the ArrangedElementCollection-ListT branch November 22, 2022 20:29
@ghost ghost locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants