Refactor WeakRefCollection to use List<WeakRefObject?> instead of ArrayList #8189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elachlan
reviewed
Nov 14, 2022
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Internals/WeakRefCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Nov 15, 2022
| @@ -30,10 +30,10 @@ public WeakRefCollection() : this(4) | |||
|
|
|||
There was a problem hiding this comment.
As a thought exercise - what if changed to this?
internal class WeakRefCollection : List<WeakRefObject?>
{
// ...
}There was a problem hiding this comment.
I don't think we can do this easily and within the scope of this PR but you should raise a new issue where this can be debated. Changing the interface (or the class derived from) most likely would mean overriding several new methods.
src/System.Windows.Forms.Primitives/src/System/Windows/Forms/Internals/WeakRefCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
added
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
RussKie
removed
the
waiting-on-team
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8140
Microsoft Reviewers: Open in CodeFlow