Refactor several data grid view classes to use List<T> instead of ArrayList #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jericho
commented
Nov 14, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedCellCollection.cs
Outdated
Show resolved
Hide resolved
Jericho
commented
Nov 14, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedColumnCollection.cs
Outdated
Show resolved
Hide resolved
Jericho
commented
Nov 14, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedRowCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Nov 15, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewCellCollection.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewCellCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
reviewed
Nov 15, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewCellCollection.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedCellCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
Jericho
force-pushed
the
GH-8140_DataGridView
branch
from
c35e3aa
to
a8d2229
Compare
dreddy-work
reviewed
Nov 15, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewCellCollection.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Nov 15, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedCellCollection.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
Jericho
force-pushed
the
GH-8140_DataGridView
branch
from
ad8364c
to
7880e0a
Compare
RussKie
reviewed
Nov 16, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedRowCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
added
the
📭 waiting-author-feedback
ghost
removed
the
📭 waiting-author-feedback
RussKie
reviewed
Nov 16, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedColumnCollection.cs
Outdated
Show resolved
Hide resolved
RussKie
previously approved these changes
Nov 16, 2022
…ell> instead of ArrayList
…wColumn> instead of ArrayList
…w> instead of ArrayList
…tead of ArrayList
…> instead of ArrayList
…CellCollection.cs Co-authored-by: Igor Velikorossov <[email protected]>
…SelectedCellCollection.cs Co-authored-by: Igor Velikorossov <[email protected]>
…SelectedRowCollection.cs Co-authored-by: Igor Velikorossov <[email protected]>
…SelectedColumnCollection.cs Co-authored-by: Igor Velikorossov <[email protected]>
Jericho
force-pushed
the
GH-8140_DataGridView
branch
from
e8af8e6
to
b2349a1
Compare
dreddy-work
reviewed
Nov 17, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedCellCollection.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Nov 17, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedColumnCollection.cs
Outdated
Show resolved
Hide resolved
dreddy-work
reviewed
Nov 17, 2022
src/System.Windows.Forms/src/System/Windows/Forms/DataGridViewSelectedRowCollection.cs
Outdated
Show resolved
Hide resolved
dreddy-work
added
the
📭 waiting-author-feedback
Co-authored-by: Devendar Reddy Adulla <[email protected]>
Co-authored-by: Devendar Reddy Adulla <[email protected]>
ghost
removed
the
📭 waiting-author-feedback
|
@dreddy-work thanks. I addressed all your comments |
dreddy-work
approved these changes
Nov 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8140
Microsoft Reviewers: Open in CodeFlow