Refactor AxPropertyDescriptor to replace ArrayList
#8152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a section where there is a Should I use ToArray() on the List instead? I wanted to keep the changes to a minimum hence why I didn't do it. |
dreddy-work
reviewed
Nov 10, 2022
src/System.Windows.Forms/src/System/Windows/Forms/AxHost.AxPropertyDescriptor.cs
Outdated
Show resolved
Hide resolved
I don't see why not. it creates a new copy of array. |
RussKie
approved these changes
Nov 10, 2022
KindDragon
reviewed
Nov 10, 2022
| @@ -268,16 +267,13 @@ internal void UpdateAttributes() | |||
| return; | |||
| } | |||
|
|
|||
| ArrayList attributes = new ArrayList(AttributeArray); | |||
| List<Attribute> attributes = new(AttributeArray); | |||
| foreach (Attribute attr in _updateAttributes) | |||
| { | |||
| attributes.Add(attr); | |||
There was a problem hiding this comment.
I think this foreach equal to
attributes.AddRange(_updateAttributes);
There was a problem hiding this comment.
Good idea. Could you put in a PR?
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
AxPropertyDescriptorto replaceArrayListwithList<T>Related: #8140
Microsoft Reviewers: Open in CodeFlow