Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AutoCompleteStringCollection to use List<string> instead of ArrayList #8142

Merged
merged 4 commits into from
Nov 10, 2022
Merged

Refactor AutoCompleteStringCollection to use List<string> instead of ArrayList #8142

merged 4 commits into from
Nov 10, 2022

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Nov 9, 2022 •
edited by ghost
Loading

Work related to #8140

Microsoft Reviewers: Open in CodeFlow

@elachlan elachlan requested a review from a team as a code owner November 9, 2022 00:34
@ghost ghost assigned elachlan Nov 9, 2022
@elachlan
Copy link
Contributor Author

elachlan commented Nov 9, 2022

@RussKie flaky test? I can't see any test failures.

@RussKie RussKie mentioned this pull request Nov 9, 2022
Merged
@RussKie
Copy link
Member

RussKie commented Nov 9, 2022

This looks like a new regression introduced by #8105.

@elachlan
Copy link
Contributor Author

Could you please rerun the pipeline?

@RussKie
Copy link
Member

RussKie commented Nov 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@RussKie
Copy link
Member

RussKie commented Nov 10, 2022

Could you please rerun the pipeline?

Done.
You could restart the build pipeline by closing the PR and then reopening it.

@RussKie RussKie enabled auto-merge (squash) November 10, 2022 05:09
RussKie
RussKie previously approved these changes Nov 10, 2022
View reviewed changes
@runfoapp runfoapp bot mentioned this pull request Nov 10, 2022
Closed
@Jericho Jericho mentioned this pull request Nov 10, 2022
Open
lonitra
lonitra previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question. Otherwise LGTM, thank you!

src/System.Windows.Forms/src/System/Windows/Forms/AutoCompleteStringCollection.cs Outdated Show resolved Hide resolved
auto-merge was automatically disabled November 10, 2022 20:37

Head branch was pushed to by a user without write access

@elachlan elachlan dismissed stale reviews from lonitra and RussKie via 47d0c06 November 10, 2022 20:37
@lonitra lonitra merged commit 094bbe9 into dotnet:main Nov 10, 2022
@ghost ghost added this to the 8.0 Preview1 milestone Nov 10, 2022
@elachlan elachlan deleted the AutoCompleteStringCollection-ListT branch November 10, 2022 21:18
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lonitra lonitra lonitra approved these changes

@RussKie RussKie RussKie left review comments

Assignees

@elachlan elachlan

Labels
None yet
Projects
None yet
Milestone
8.0 Preview1
Development

Successfully merging this pull request may close these issues.
3 participants
@elachlan @RussKie @lonitra