Fixed comparing of CultureInfo in unit tests. #8109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikitaSemenovAkvelon
requested review from
Tanya-Solyanik,
dkazennov,
dmitrii-drobotov,
dreddy-work and
v-elnovikova
NikitaSemenovAkvelon
added
the
waiting-review
dmitrii-drobotov
approved these changes
Nov 3, 2022
Tanya-Solyanik
added
ready-to-merge
Tanya-Solyanik
approved these changes
Nov 3, 2022
Tanya-Solyanik
removed
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8046
Proposed changes
Assert.Sameinstead ofAssert.EqualforCultureInfo.Customer Impact
Regression?
Risk
Test methodology
Test environment(s)
.NET SDK:
Version: 8.0.100-alpha.1.22512.5
Commit: 1b80461e45
Runtime Environment:
OS Name: Windows
OS Version: 10.0.22621
Microsoft Reviewers: Open in CodeFlow