-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Convert Shlwapi interop code to CSWin32 #7839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Usually most APIs have a length output which makes it possible to quickly ascertain the required length. But some don't and require using a loop and |
2048fb2 to
e3a29fb
Compare
|
@RussKie There is a failure based on the CI image The test failures I am unsure if they are related or flaky tests? |
|
No, the CMake is related to the build images and the tooling available in those. The failure was caused by a flaky test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs
Outdated
Show resolved
Hide resolved
e3a29fb to
9593799
Compare
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Primitives/src/Windows/Win32/PInvoke.SHAutoComplete.cs
Outdated
Show resolved
Hide resolved
9593799 to
f5150d8
Compare
f5150d8 to
e997a9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Relates to #7445
I am unsure on the
SHLoadIndirectStringchanges and would love some feedback.In MSBuild, we started with a smaller buffer and looped making it larger if the call failed. Also used
ArrayPoolin some spots. I guess it really depends on how large the returned information can technically get.dotnet/msbuild#7186
Microsoft Reviewers: Open in CodeFlow