-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Enable template localization on dotnet CLI #6319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RussKie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a lot of "noisy" changes, that don't carry any value.
| "author": "Microsoft", | ||
| "name": "Aplicación de Windows Forms", | ||
| "description": "Plantilla de proyecto para crear una aplicación de Windows Forms (WinForms) de .NET.", | ||
| "description": "Plantilla de proyecto para crear una aplicación de Windows\u00A0Forms (WinForms) de .NET.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases, loc team used hard spaces that won't break into a new line instead of a regular whitespace character. Our automated tool is configured to encode such symbols into \u#### form.
Hopefully, the tooling they are using will be able to deal with this change. But if starts going back and forth, we will update the tool to preserve the current encoding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bekir-ozturk , this change is causing the problem. Loc pipeline converted this back to its original state removing the \u####. But local build adds it back and thus every time you sync with main and try to build repo locally, you will be getting this unwanted change as modified one. Is this change communicated to loc pipeline?
...Microsoft.Dotnet.WinForms.ProjectTemplates/Microsoft.Dotnet.Winforms.ProjectTemplates.csproj
Outdated
Show resolved
Hide resolved
|
Hello @RussKie! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to oblige
Untill the issue discussed here #6319 (comment) resolved.
Untill the issue discussed here #6319 (comment) resolved.
Untill the issue discussed here dotnet#6319 (comment) resolved.
Background:
Template engine (
dotnet new) added support for template localizations in .NET 6.0. This new system replaces the old way of localizing templates that only worked on Visual Studio and works on both .NET CLI as well as VS.This PR introduces changes to switch to the new template localization system.
Summary of the changes
<UsingToolTemplateLocalizer>true</>to projects containing templates.idfields intotemplate.jsonfiles to allow localizing certain fields (specifically, post actions).What to expect after merging
Every time there is a change to one of the templates:
Microsoft Reviewers: Open in CodeFlow