Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary NRT directives from TaskDialog interop files #3602

Merged

Conversation

kpreisser
Copy link
Contributor

@kpreisser kpreisser commented Jul 19, 2020

Remove now unnecessary NRT directives that were added by #1133, since #3451 enabled nullable reference types for System.Windows.Forms.Primitives globally in the project file.

Proposed changes

  • Remove remaining #nullable enable directives in System.Windows.Forms.Primitives files.

Customer Impact

  • None

Regression?

  • No

Risk

Test methodology

  • Changed one of the field types in PFTASKDIALOGCALLBACK to object? and verified that the compiler doesn't raise CS8632.

Test environment(s)

.NET SDK (reflecting any global.json):
Version: 5.0.100-rc.1.20367.2
Commit: 0dd3ff77c7

Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.100-rc.1.20367.2\

Host (useful for support):
Version: 5.0.0-preview.8.20361.2
Commit: f37dd6fc85

.NET SDKs installed:
3.1.400-preview-015203 [C:\Program Files\dotnet\sdk]
5.0.100-rc.1.20367.2 [C:\Program Files\dotnet\sdk]

Microsoft Reviewers: Open in CodeFlow

@kpreisser kpreisser requested a review from a team as a code owner July 19, 2020 13:03
@ghost ghost assigned kpreisser Jul 19, 2020
@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #3602 into master will decrease coverage by 31.66996%.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##              master       #3602          +/-   ##
====================================================
- Coverage   67.04925%   35.37929%   -31.66997%     
====================================================
  Files           1364         905         -459     
  Lines         503861      250771      -253090     
  Branches       40782       36601        -4181     
====================================================
- Hits          337835       88721      -249114     
+ Misses        160459      157204        -3255     
+ Partials        5567        4846         -721     
Flag Coverage Δ
#Debug 35.37929% <ø> (-31.66997%) ⬇️
#production 35.37929% <ø> (ø)
#test ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@kpreisser kpreisser mentioned this pull request Jul 19, 2020
3 tasks
@JeremyKuhne JeremyKuhne merged commit c7040f2 into dotnet:master Jul 22, 2020
@ghost ghost added this to the 5.0 RC1 milestone Jul 22, 2020
@JeremyKuhne
Copy link
Member

Thanks @kpreisser

@kpreisser kpreisser deleted the removeUnnecessaryNullableDirectives branch July 22, 2020 06:39
@ghost ghost locked as resolved and limited conversation to collaborators Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants