[Refactoring] Added protection for MonthCalendarAccessibleObject #2975

vladimir-krestov · 2020-03-14T07:54:33Z

Added protection for MonthCalendarAccessibleObject against incorrect parameters of methods to avoid exceptions throwing

Related Issue An exception occurred when MonthCalendar switched dates #2912
Related PR Fixing MCGRIDINFO definition #2911
Related PR [Regression] Fixing MonthCalendar NRE when MinDate is set #3041

Proposed changes

Add parentAccessibleObject null condition for GetCalendarCell method to avoid NullReferenceException throwing when getting rowIndex value on 373 line (MonthCalendar.MonthCalendarAccessibleObject.cs)
Check SYSTEMTIME parameter value for SysTimeToDateTime method to get correct DateTime value (DateTimePicker.cs)
Add unit tests

Customer Impact

User apps won't crash in these methods when there are incorrect parameters

Regression?

No

Risk

Minimal

Test methodology

Unit testing
Manual testing
CTI

Test environment(s)

.NET Core SDK: 5.0.0-alpha.1.20072.3
Microsoft Windows [Version 10.0.18363.592]

Microsoft Reviewers: Open in CodeFlow

vladimir-krestov · 2020-03-14T08:44:39Z

Hm, dotnet-winforms CI isn't passed. I didn't catch why.
The build and unit tests are success localy.
@RussKie could you please help?

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DateTimePickerTests.cs

codecov · 2020-03-14T09:44:40Z

Codecov Report

Merging #2975 into master will decrease coverage by 36.50246%.
The diff coverage is 59.13978%.

@@                 Coverage Diff                  @@
##              master       #2975          +/-   ##
====================================================
- Coverage   98.63134%   62.12888%   -36.50246%     
====================================================
  Files            422        1292         +870     
  Lines         202096      456192      +254096     
  Branches        2814       39576       +36762     
====================================================
+ Hits          199330      283427       +84097     
- Misses          2218      167401      +165183     
- Partials         548        5364        +4816

Flag	Coverage Δ
#Debug	`62.12888% <59.13978%> (-36.50246%)`	⬇️
#production	`33.08417% <16.27907%> (?)`
#test	`98.63069% <96.00000%> (-0.00065%)`	⬇️

vladimir-krestov · 2020-03-14T09:46:58Z

I have solved CI build issue. Thanks, @weltkante.
I just swapped Debug.Fail to Debug.WriteLine

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DateTimePickerTests.cs

vladimir-krestov · 2020-03-16T07:06:56Z

@RussKie, I'll start CTI testing when you approve.

to get correct data from WinAPI messages Fixes Issue dotnet#2912 Related Issue dotnet#2475 Related PR dotnet#2975

To get correct data from WinAPI messages Fixes #2912 Related Issue #2475 Related PR #2975

RussKie

👍

RussKie · 2020-04-06T05:09:43Z

Please prepare a patch for 3.1 as well.

RussKie

👍

RussKie

Great job!

Do you feel that having created MauiMonthCalendarTests we still need tests employing RemoteExecutor?

....Forms/tests/UnitTests/AccessibleObjects/MonthCalendar.MonthCalendarAccessibleObjectTests.cs

...System.Windows.Forms/src/System/Windows/Forms/MonthCalendar.MonthCalendarAccessibleObject.cs

src/System.Windows.Forms/tests/IntegrationTests/MauiTests/MauiTestsHelper/KeyBoardHelper.cs

...System.Windows.Forms/tests/IntegrationTests/MauiTests/MauiListViewTests/MauiListViewTests.cs

src/System.Windows.Forms/tests/IntegrationTests/MauiTests/MauiTestsHelper/MouseHelper.cs

src/System.Windows.Forms/tests/IntegrationTests/WinformsControlsTest/Calendar.Designer.cs

vladimir-krestov · 2020-05-07T04:37:29Z

Do you feel that having created MauiMonthCalendarTests we still need tests employing RemoteExecutor?

No, I have removed the unit tests. All test cases are implemented as maui tests.
Thank you.

RussKie

👍

RussKie · 2020-05-08T06:51:36Z

Please rebase on the latest - the failing MAUI test was fixed by @M-Lipin.

vladimir-krestov · 2020-05-08T06:52:45Z

Cool, thank you!

vladimir-krestov · 2020-05-10T09:10:31Z

Testers approved the fix ✔️

...dows.Forms/tests/IntegrationTests/MauiTests/MauiMonthCalendarTests/MauiMonthCalendarTests.cs

against incorrect parameters of methods to avoid exception throwing Related Issues dotnet#2912 and dotnet#2475 Related PR dotnet#2911

vladimir-krestov · 2020-05-14T06:17:17Z

PR is ready, please check.

vladimir-krestov requested a review from a team as a code owner March 14, 2020 07:54

ghost assigned vladimir-krestov Mar 14, 2020

vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Mar 14, 2020

vladimir-krestov requested a review from RussKie March 14, 2020 07:55

vladimir-krestov mentioned this pull request Mar 14, 2020

Fixing MCGRIDINFO definition #2911

Merged

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 138805c to cbb6b23 Compare March 14, 2020 08:46

weltkante reviewed Mar 14, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DateTimePickerTests.cs Outdated Show resolved Hide resolved

RussKie requested changes Mar 16, 2020

View reviewed changes

src/System.Windows.Forms/tests/UnitTests/System/Windows/Forms/DateTimePickerTests.cs Outdated Show resolved Hide resolved

ghost added the waiting-author-feedback The team requires more information from the author label Mar 16, 2020

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Mar 16, 2020

ghost removed the waiting-author-feedback The team requires more information from the author label Mar 16, 2020

vladimir-krestov changed the title ~~[Refactoring] Added protection for MonthCalendarAccessibleObject~~ WIP: [Refactoring] Added protection for MonthCalendarAccessibleObject Mar 16, 2020

vladimir-krestov added the waiting-review This item is waiting on review by one or more members of team label Mar 16, 2020

vladimir-krestov added a commit to vladimir-krestov/winforms that referenced this pull request Mar 23, 2020

Fixed MCGRIDINFO definition

8c3830f

to get correct data from WinAPI messages Fixes Issue dotnet#2912 Related Issue dotnet#2475 Related PR dotnet#2975

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 4a2637d to 87d2ce7 Compare March 23, 2020 20:06

vladimir-krestov added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label Mar 23, 2020

RussKie pushed a commit that referenced this pull request Mar 24, 2020

Fixing MCGRIDINFO definition (#2911)

e75f8af

To get correct data from WinAPI messages Fixes #2912 Related Issue #2475 Related PR #2975

RussKie reviewed Mar 24, 2020

View reviewed changes

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Mar 24, 2020

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from e653f04 to 1b38364 Compare March 24, 2020 08:41

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 1b38364 to 4dca299 Compare April 6, 2020 15:22

vladimir-krestov mentioned this pull request Apr 6, 2020

[Regression] Fixing MonthCalendar NRE when MinDate is set #3041

Merged

vladimir-krestov changed the title ~~WIP: [Refactoring] Added protection for MonthCalendarAccessibleObject~~ [Refactoring] Added protection for MonthCalendarAccessibleObject Apr 6, 2020

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 832b149 to 7c01e91 Compare April 12, 2020 17:26

vladimir-krestov changed the title ~~WIP: [Refactoring] Added protection for MonthCalendarAccessibleObject~~ [Refactoring] Added protection for MonthCalendarAccessibleObject Apr 20, 2020

RussKie reviewed Apr 20, 2020

View reviewed changes

RussKie removed the waiting-review This item is waiting on review by one or more members of team label Apr 20, 2020

RussKie marked this pull request as draft April 20, 2020 06:00

RussKie reviewed Apr 27, 2020

View reviewed changes

vladimir-krestov removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label May 6, 2020

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 1ea973f to a65123d Compare May 6, 2020 12:33

vladimir-krestov added the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label May 6, 2020

RussKie reviewed May 8, 2020

View reviewed changes

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from a65123d to 60faf3d Compare May 8, 2020 07:27

vladimir-krestov removed the waiting-for-testing The PR is awaiting manual testing by the primary team; no action is yet required from the author(s) label May 10, 2020

vladimir-krestov closed this May 10, 2020

vladimir-krestov reopened this May 10, 2020

vladimir-krestov marked this pull request as ready for review May 10, 2020 09:11

RussKie reviewed May 11, 2020

View reviewed changes

...dows.Forms/tests/IntegrationTests/MauiTests/MauiMonthCalendarTests/MauiMonthCalendarTests.cs Show resolved Hide resolved

...dows.Forms/tests/IntegrationTests/MauiTests/MauiMonthCalendarTests/MauiMonthCalendarTests.cs Show resolved Hide resolved

Added protection for MonthCalendarAccessibleObject

7493527

against incorrect parameters of methods to avoid exception throwing Related Issues dotnet#2912 and dotnet#2475 Related PR dotnet#2911

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 5182bb4 to 5b96cf9 Compare May 12, 2020 06:30

vladimir-krestov added 2 commits May 12, 2020 10:55

Added unit and maui tests to check MonthCalendarAccessibleObject

6c8a987

Fixed getting ColumnHeaderItems AccessibleObjects for MonthCalendar

1635bc5

vladimir-krestov force-pushed the dev/v-vlkres/2475_ProptectMonthCalendar branch from 5b96cf9 to 1635bc5 Compare May 12, 2020 07:58

RussKie approved these changes May 15, 2020

View reviewed changes

RussKie merged commit e06255c into dotnet:master May 15, 2020

ghost added this to the 5.0 Preview6 milestone May 15, 2020

vladimir-krestov deleted the dev/v-vlkres/2475_ProptectMonthCalendar branch November 4, 2020 07:36

ghost locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Refactoring] Added protection for MonthCalendarAccessibleObject #2975

[Refactoring] Added protection for MonthCalendarAccessibleObject #2975

vladimir-krestov commented Mar 14, 2020 •

edited

Loading

vladimir-krestov commented Mar 14, 2020

codecov bot commented Mar 14, 2020 •

edited

Loading

vladimir-krestov commented Mar 14, 2020

vladimir-krestov commented Mar 16, 2020

RussKie left a comment

RussKie commented Apr 6, 2020

RussKie left a comment

RussKie left a comment

vladimir-krestov commented May 7, 2020

RussKie left a comment

RussKie commented May 8, 2020

vladimir-krestov commented May 8, 2020

vladimir-krestov commented May 10, 2020

vladimir-krestov commented May 14, 2020

[Refactoring] Added protection for MonthCalendarAccessibleObject #2975

[Refactoring] Added protection for MonthCalendarAccessibleObject #2975

Conversation

vladimir-krestov commented Mar 14, 2020 • edited Loading

Proposed changes

Customer Impact

Regression?

Risk

Test methodology

Test environment(s)

Microsoft Reviewers: Open in CodeFlow

vladimir-krestov commented Mar 14, 2020

codecov bot commented Mar 14, 2020 • edited Loading

Codecov Report

vladimir-krestov commented Mar 14, 2020

vladimir-krestov commented Mar 16, 2020

RussKie left a comment

Choose a reason for hiding this comment

RussKie commented Apr 6, 2020

RussKie left a comment

Choose a reason for hiding this comment

RussKie left a comment

Choose a reason for hiding this comment

vladimir-krestov commented May 7, 2020

RussKie left a comment

Choose a reason for hiding this comment

RussKie commented May 8, 2020

vladimir-krestov commented May 8, 2020

vladimir-krestov commented May 10, 2020

vladimir-krestov commented May 14, 2020

vladimir-krestov commented Mar 14, 2020 •

edited

Loading

codecov bot commented Mar 14, 2020 •

edited

Loading