-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling NRT for SWF (no API changes yet) #2702
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2702 +/- ##
==================================================
+ Coverage 58.88815% 58.90005% +0.0119%
==================================================
Files 1242 1242
Lines 428565 428565
Branches 38912 38912
==================================================
+ Hits 252374 252425 +51
+ Misses 170849 170796 -53
- Partials 5342 5344 +2
|
I just did a full eye-check on the API and found a couple of changes: one for a file I had considered as safe and the other one for a file I forgot to edit. |
I will need to get #2705 before this can go in. |
@RussKie Oh, I didn't know about that txt files feature. That's exactly what I needed for the API diff. While rebasing, I removed that change from this branch and also filed #2708. After merged, this branch (and #2676) can be rebased again and the diagnosis will tell us if we have any undesired API changes (my local merge tells me this branch doesn't). |
@RussKie rebasing didn't throw any warning, I guess we're good to go. |
Let's breaking it up in two:
Right now commit 53bac09def1dc10c0674e5bdd39636e3c476dd92 undo changes made in dfd4820ab5f5947d0efc9784a74e9bc9096b69f8. |
@RussKie done. This PR is acting as the first one you mentioned. I'm ready to send the other one once this one is merged. |
Missed a new file from 9dc2a1d. It's an internal class, so it didn't show up in the API diff. |
Thank you |
Work for #1107.
Refers to #2678.
Relates to #2676.
Changes
<Nullable>enable</Nullable>
toSystem.Windows.Forms.csproj
.#nullable disable
to everysrc/System.Windows.Forms/src/**/*.cs
file header.Next steps
cc @RussKie @sharwell @hughbe
Microsoft Reviewers: Open in CodeFlow