Skip to content

Conversation

@LeafShi1
Copy link
Member

@LeafShi1 LeafShi1 commented Jul 26, 2024

Fixes #11760

Proposed changes

Customer Impact

  • The ToolStripComboBox can be used normally without weird display

Regression?

  • Yes

Risk

  • Minimal

Screenshots

Before

When hovering over drop-down arrow of ToolStripComboBox, an additional blue hover effect appears outside the icon.

ToolStripComboBox.mp4

After

No additional blue hover effect appears outside the icon.

KeepSmallButton

Test methodology

  • Manually

Test environment(s)

  • 9.0.0-preview.7.24370.5
Microsoft Reviewers: Open in CodeFlow

@codecov
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 74.83942%. Comparing base (c0318e5) to head (a429cb9).
Report is 26 commits behind head on main.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main      #11761         +/-   ##
===================================================
+ Coverage   74.73622%   74.83942%   +0.10320%     
===================================================
  Files           3045        3013         -32     
  Lines         630638      629270       -1368     
  Branches       46862       46693        -169     
===================================================
- Hits          471315      470942        -373     
+ Misses        155957      154969        -988     
+ Partials        3366        3359          -7     
Flag Coverage Δ
Debug 74.83942% <30.00000%> (+0.10320%) ⬆️
integration 18.03225% <0.00000%> (+0.08799%) ⬆️
production 47.83505% <30.00000%> (+0.07712%) ⬆️
test 97.01255% <ø> (+0.02721%) ⬆️
unit 44.83673% <30.00000%> (+0.03185%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Tanya-Solyanik Tanya-Solyanik added this to the 9.0 RC1 milestone Jul 26, 2024
@LeafShi1 LeafShi1 force-pushed the Issue_11760_Fix_ToolStripComboBox_display branch from 689a331 to 2169190 Compare July 29, 2024 06:07
@LeafShi1 LeafShi1 marked this pull request as ready for review July 29, 2024 06:09
@LeafShi1 LeafShi1 requested a review from a team as a code owner July 29, 2024 06:09
@LeafShi1 LeafShi1 requested a review from Tanya-Solyanik July 29, 2024 06:09
@dotnet-policy-service dotnet-policy-service bot removed the draft draft PR label Jul 29, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Jul 30, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Jul 31, 2024
@lonitra lonitra added the waiting-author-feedback The team requires more information from the author label Jul 31, 2024
@dotnet-policy-service dotnet-policy-service bot removed the waiting-author-feedback The team requires more information from the author label Aug 1, 2024
Copy link
Contributor

@Tanya-Solyanik Tanya-Solyanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Tanya-Solyanik Tanya-Solyanik merged commit bb6335d into dotnet:main Aug 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird display when hovering to ToolStripComboBox drop down arrow

3 participants