Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ArrayList usage in ToolStripItemDataObject with List #10626

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Replace ArrayList usage in ToolStripItemDataObject with List #10626

merged 3 commits into from
Jan 24, 2024

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Jan 9, 2024 •
edited by ghost
Loading

Contributes to #8140

Proposed changes

  • Replace ArrayList usage in ToolStripItemDataObject with List
  • Update relevant call sites to move off IList and ICollection interfaces
Microsoft Reviewers: Open in CodeFlow

@halgab halgab requested a review from a team as a code owner January 9, 2024 22:32
@ghost ghost assigned halgab Jan 9, 2024
@halgab halgab mentioned this pull request Jan 9, 2024
Merged
@elachlan
Copy link
Contributor 

ToolStripItemBehavior.cs(656,119): error CS0103: (NETCORE_ENGINEERING_TELEMETRY=Build) The name 'components' does not exist in the current context

@halgab
Copy link
Contributor Author

halgab commented Jan 10, 2024

As mentioned here, this change might not be a no-brainer though...

@elachlan
Copy link
Contributor

ToolStripMenuItemDesigner in the DemoConsole has had problems testing in the past see #9413

@elachlan
Copy link
Contributor

@Olina-Zhang Is it possible for your team to test this? (I am not sure if it is, because demo console might not enable testing this)

I am concerned about the changes to ToolStripItemDataObject which is used "when a ToolStripItem is Drag-Dropped during DesignTime".

@halgab
Copy link
Contributor Author

halgab commented Jan 12, 2024

Abandoning this pr altogether is also a very acceptable outcome if we're not comfortable with it

@Olina-Zhang
Copy link
Member

@elachlan @halgab We haven't started the test yet, should we run the test for this PR?

@halgab
Copy link
Contributor Author

halgab commented Jan 12, 2024

If you don't mind doing it, of course, please go ahead. Thanks a lot

@Olina-Zhang
Copy link
Member

Tested this PR with some toolStripItems drag and drop scenarios in design time, no new issue found.

GH10626_testing.mp4

@elachlan
Copy link
Contributor

Thanks @Olina-Zhang! We can definitely merge this then

lonitra
lonitra approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lonitra lonitra merged commit aa3a6a1 into dotnet:main Jan 24, 2024
9 checks passed
@ghost ghost added this to the 9.0 Preview2 milestone Jan 24, 2024
@halgab halgab deleted the ToolStripItemDataObject-ArrayList branch January 24, 2024 17:11
@MandiMan
Copy link
Contributor

MandiMan commented Feb 2, 2024

Tested this PR on .NET 9.0.0-preview.2.24076.2 with dlls built from winforms repo of main branch, no new issue found.

10626.mp4

@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elachlan elachlan elachlan left review comments

@lonitra lonitra lonitra approved these changes

Assignees

@halgab halgab

Labels
None yet
Projects
None yet
Milestone
9.0 Preview2
Development

Successfully merging this pull request may close these issues.
5 participants
@halgab @elachlan @Olina-Zhang @MandiMan @lonitra