Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace ArrayList with List<T> in TableLayoutPanelDesigner #10287

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Replace ArrayList with List<T> in TableLayoutPanelDesigner #10287

merged 4 commits into from
Nov 14, 2023

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Nov 13, 2023 •
edited by ghost
Loading

Contributes to #8140

I fixed the impacted field name in the same PR (in a separate commit) to make it easier to review all its call sites

Proposed changes

  • Replace all ArrayLists with List<T> in TableLayoutPanelDesigner
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab Nov 13, 2023
@halgab halgab mentioned this pull request Nov 13, 2023
Merged
@halgab
Copy link
Contributor Author

halgab commented Nov 13, 2023

cc @elachlan

@halgab halgab marked this pull request as ready for review November 13, 2023 22:35
@halgab halgab requested a review from a team as a code owner November 13, 2023 22:35
JeremyKuhne
JeremyKuhne approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@JeremyKuhne JeremyKuhne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JeremyKuhne JeremyKuhne merged commit 1b39374 into dotnet:main Nov 14, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Nov 14, 2023
@halgab halgab deleted the TableLayoutPanelDesigner-ArrayList branch November 14, 2023 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JeremyKuhne JeremyKuhne JeremyKuhne approved these changes

Assignees

@halgab halgab

Labels
None yet
Projects
None yet
Milestone
9.0 Preview1
Development

Successfully merging this pull request may close these issues.
2 participants
@halgab @JeremyKuhne