Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ResizeBehavior to use List<T> instead of ArrayList #10236

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

elachlan
Copy link
Contributor

@elachlan elachlan commented Nov 7, 2023

  • Refactor ResizeBehavior to use List<T> instead of ArrayList
  • Refactor ResizeComponent.resizeControl from object to Control to remove casting

Related: #8140

Microsoft Reviewers: Open in CodeFlow

Refactor private struct ResizeComponent.resizeControl to Control to remove casting
@elachlan elachlan requested a review from a team as a code owner November 7, 2023 07:17
@ghost ghost assigned elachlan Nov 7, 2023
@elachlan
Copy link
Contributor Author

elachlan commented Nov 7, 2023

@lonitra test failure looks unusual and unrelated:

Process terminated. Encountered infinite recursion while looking up resource 'Arg_NullReferenceException' in System.Private.CoreLib. Verify the installation of .NET is complete and does not need repairing, and that the state of the process has not become corrupted.
   at System.Environment.FailFast(System.String)
   at System.SR.InternalGetResourceString(System.String)
   at System.SR.GetResourceString(System.String)
   at System.NullReferenceException..ctor()
   at System.Resources.ResourceManager.GetString(System.String, System.Globalization.CultureInfo)
   at System.SR.InternalGetResourceString(System.String)
   at System.SR.GetResourceString(System.String)
   at System.NullReferenceException..ctor()
   at System.Windows.Forms.Application+ThreadContext.FromCurrent()
   at System.Windows.Forms.Application.FormActivated(Boolean, Boolean)
   at System.Windows.Forms.Form.WmActivate(System.Windows.Forms.Message ByRef)
   at System.Windows.Forms.Form.WndProc(System.Windows.Forms.Message ByRef)
   at System.Windows.Forms.NativeWindow.Callback(Windows.Win32.Foundation.HWND, Windows.Win32.MessageId, Windows.Win32.Foundation.W

@lonitra
Copy link
Member

lonitra commented Nov 8, 2023

Agree this looks unrelated. Reran the tests. Will take a look at this PR soon

Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Nov 13, 2023
@lonitra lonitra merged commit 20d3db4 into dotnet:main Nov 14, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Nov 14, 2023
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Nov 14, 2023
@elachlan elachlan deleted the ResizeBehavior-ArrayList branch November 14, 2023 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants