Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nullability in DesignerUtils #10183

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

halgab
Copy link
Contributor

@halgab halgab commented Oct 24, 2023

This replaces #9381 now that #10091 and #10092 are merged.

I also considered reusing that PR, but it was too different. If you feel like this goes against the decision made here, feel free to close this PR. My take on it is that it finishes already started work.

Proposed changes

  • Enable nullability in internal helper DesignerUtils
Microsoft Reviewers: Open in CodeFlow

@ghost ghost assigned halgab Oct 24, 2023
@ghost ghost added the area: NRT label Oct 24, 2023
@halgab halgab marked this pull request as ready for review October 24, 2023 13:14
@halgab halgab requested a review from a team as a code owner October 24, 2023 13:14
Copy link
Member

@lonitra lonitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't mind taking this as you originally had an older PR addressing this. Once this is merged, can #9381 be closed then?

@lonitra lonitra added the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 26, 2023
@halgab
Copy link
Contributor Author

halgab commented Oct 26, 2023

Yep, that's what I had in mind

@lonitra lonitra merged commit 3723eb1 into dotnet:main Oct 27, 2023
9 checks passed
@ghost ghost added this to the 9.0 Preview1 milestone Oct 27, 2023
@ghost ghost removed the ready-to-merge PRs that are ready to merge but worth notifying the internal team. label Oct 27, 2023
@halgab halgab deleted the DesignerUtils-null branch October 27, 2023 17:43
@halgab
Copy link
Contributor Author

halgab commented Oct 27, 2023

LGTM. I don't mind taking this as you originally had an older PR addressing this. Once this is merged, can #9381 be closed then?

I've just closed it

@ghost ghost locked as resolved and limited conversation to collaborators Nov 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants