Skip to content

Commit

Permalink
Respond to feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
JeremyKuhne committed Aug 25, 2021
1 parent 12fe1f4 commit 5dc2810
Show file tree
Hide file tree
Showing 20 changed files with 216 additions and 152 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,24 +26,24 @@ public interface IRawElementProviderFragment : IRawElementProviderSimple
/// Returns the element in the specified <paramref name="direction"/>.
/// </summary>
/// <param name="direction">Indicates the direction in which to navigate.</param>
/// <returns>Returns the element in the specified direction if it exists.</returns>
/// <returns>The element in the specified direction, if it exists.</returns>
[return: MarshalAs(UnmanagedType.IUnknown)]
object? /*IRawElementProviderFragment*/ Navigate(NavigateDirection direction);

/// <summary>
/// Gets the runtime ID of an element. This should be unique
/// among elements on a desktop.
/// Gets the runtime ID of an element. This should be unique among elements on a desktop.
/// </summary>
/// <remarks>
/// Proxy implementations should return null for the top-level proxy which
/// corresponds to the HWND; and should return an array which starts
/// with AutomationInteropProvider.AppendRuntimeId, followed by values
/// which are then unique within that proxy's HWNDs.
/// <para>
/// Proxy implementations should return null for the top-level proxy which corresponds to the HWND;
/// and should return an array which starts with AutomationInteropProvider.AppendRuntimeId", followed by
/// values which are then unique within that proxy's HWNDs.
/// </para>
/// </remarks>
int[]? GetRuntimeId();

/// <summary>
/// Return a bounding rectangle of this element
/// Return a bounding rectangle of this element.
/// </summary>
UiaRect BoundingRectangle { get; }

Expand All @@ -59,10 +59,12 @@ public interface IRawElementProviderFragment : IRawElementProviderSimple

/// <summary>
/// Request that focus is set to this item.
/// </summary>
/// <remarks>
/// The UIAutomation framework will ensure that the UI hosting this fragment is already
/// focused before calling this method, so this method should only update its internal
/// focus state; it should not attempt to give its own HWND the focus, for example.
/// </summary>
/// </remarks>
void SetFocus();

/// <summary>
Expand Down
69 changes: 64 additions & 5 deletions src/System.Windows.Forms/src/Resources/SR.resx
Original file line number Diff line number Diff line change
@@ -1,5 +1,64 @@
<?xml version="1.0" encoding="utf-8"?>
<root>
<!--
Microsoft ResX Schema
Version 2.0
The primary goals of this format is to allow a simple XML format
that is mostly human readable. The generation and parsing of the
various data types are done through the TypeConverter classes
associated with the data types.
Example:
... ado.net/XML headers & schema ...
<resheader name="resmimetype">text/microsoft-resx</resheader>
<resheader name="version">2.0</resheader>
<resheader name="reader">System.Resources.ResXResourceReader, System.Windows.Forms, ...</resheader>
<resheader name="writer">System.Resources.ResXResourceWriter, System.Windows.Forms, ...</resheader>
<data name="Name1"><value>this is my long string</value><comment>this is a comment</comment></data>
<data name="Color1" type="System.Drawing.Color, System.Drawing">Blue</data>
<data name="Bitmap1" mimetype="application/x-microsoft.net.object.binary.base64">
<value>[base64 mime encoded serialized .NET Framework object]</value>
</data>
<data name="Icon1" type="System.Drawing.Icon, System.Drawing" mimetype="application/x-microsoft.net.object.bytearray.base64">
<value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
<comment>This is a comment</comment>
</data>
There are any number of "resheader" rows that contain simple
name/value pairs.
Each data row contains a name, and value. The row also contains a
type or mimetype. Type corresponds to a .NET class that support
text/value conversion through the TypeConverter architecture.
Classes that don't support this are serialized and stored with the
mimetype set.
The mimetype is used for serialized objects, and tells the
ResXResourceReader how to depersist the object. This is currently not
extensible. For a given mimetype the value must be set accordingly:
Note - application/x-microsoft.net.object.binary.base64 is the format
that the ResXResourceWriter will generate, however the reader can
read any of the formats listed below.
mimetype: application/x-microsoft.net.object.binary.base64
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
: and then encoded with base64 encoding.
mimetype: application/x-microsoft.net.object.soap.base64
value : The object must be serialized with
: System.Runtime.Serialization.Formatters.Soap.SoapFormatter
: and then encoded with base64 encoding.
mimetype: application/x-microsoft.net.object.bytearray.base64
value : The object must be serialized into a byte array
: using a System.ComponentModel.TypeConverter
: and then encoded with base64 encoding.
-->
<xsd:schema id="root" xmlns="" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:msdata="urn:schemas-microsoft-com:xml-msdata">
<xsd:import namespace="http://www.w3.org/XML/1998/namespace" />
<xsd:element name="root" msdata:IsDataSet="true">
Expand Down Expand Up @@ -53,10 +112,10 @@
<value>2.0</value>
</resheader>
<resheader name="reader">
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
<value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=42.42.42.42, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<resheader name="writer">
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
<value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=42.42.42.42, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
</resheader>
<data name="AboutBoxDesc" xml:space="preserve">
<value>Displays the 'About' box for this component</value>
Expand Down Expand Up @@ -4361,7 +4420,7 @@ Stack trace where the illegal operation occurred was:
<data name="PanelBorderStyleDescr" xml:space="preserve">
<value>Indicates whether the panel should have a border.</value>
</data>
<data name="PBRSDocCommentPaneTitle" xml:space="preserve">
<data name="PropertyGridHelpPaneTitle" xml:space="preserve">
<value>Description</value>
</data>
<data name="PBRSErrorInvalidPropertyValue" xml:space="preserve">
Expand Down Expand Up @@ -4802,7 +4861,7 @@ Stack trace where the illegal operation occurred was:
<data name="PropertyGridDefaultAccessibleNameTemplate" xml:space="preserve">
<value>{0} Properties Window</value>
</data>
<data name="PropertyGridDocCommentAccessibleNameTemplate" xml:space="preserve">
<data name="PropertyGridHelpPaneAccessibleNameTemplate" xml:space="preserve">
<value>{0} Description</value>
</data>
<data name="PropertyGridDisabledItemForeColorDesc" xml:space="preserve">
Expand Down Expand Up @@ -6779,4 +6838,4 @@ Stack trace where the illegal operation occurred was:
<data name="ProfessionalColorsStatusStripBorderDescr" xml:space="preserve">
<value>Border color to use on the top edge of the StatusStrip.</value>
</data>
</root>
</root>
20 changes: 10 additions & 10 deletions src/System.Windows.Forms/src/Resources/xlf/SR.cs.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions src/System.Windows.Forms/src/Resources/xlf/SR.de.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions src/System.Windows.Forms/src/Resources/xlf/SR.es.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions src/System.Windows.Forms/src/Resources/xlf/SR.fr.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions src/System.Windows.Forms/src/Resources/xlf/SR.it.xlf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 5dc2810

Please sign in to comment.