Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-svcutil test: fix ParamsFiles and typereuse cases #5052

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

imcarolwang
Copy link
Contributor

The ParamsFiles case tests global tool can generate wcf client using parameter file passed in, typereuse case tests type reuse feature, both cases hard coded the context test project to .net6.0.

With the wcf repository's root global.json upgrades SDK version to .net8.0, the tests failed to run because the test code can only create test projects whose framework targets are available as defined by the global.json.

This PR changes net6.0 to net8.0 for the two cases and add their corresponding baseline files, also deletes baseline folder ParamsFiles_SDK_TFM/TFnetcoreapp3_1 which is no longer baseline of any existing case.

@HongGit
Copy link
Contributor

HongGit commented Jun 20, 2023

@imcarolwang can you please research to see if it's possible to make a global variable or somewhere so all the code path could benefit in the future?

@HongGit
Copy link
Contributor

HongGit commented Jul 5, 2023

I agree with the latest approach, is there a concern that using the default framework may not be include all the test framework needed to be tested?

@imcarolwang
Copy link
Contributor Author

I agree with the latest approach, is there a concern that using the default framework may not be include all the test framework needed to be tested?

I think it's ok because before updating to use default framework, test hard coded to use the latest framework version, which is no different than use the default, and we have other tests to cover different framework option test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants