Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCF Docker Containers #4876

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

WCF Docker Containers #4876

wants to merge 12 commits into from

Conversation

afifi-ins
Copy link
Contributor

No description provided.

@dnfadmin
Copy link

dnfadmin commented Aug 6, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

mconnew
mconnew reviewed Oct 24, 2022
View reviewed changes
src/System.Private.ServiceModel/tools/CertificateGenerator/App.config
@@ -6,6 +6,6 @@
<add key="CrlFileLocation" value="c:\wcftest\test.crl"/>
</appSettings>
<startup>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5"/>
<supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.8"/>
</startup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for raising the supported runtime version to 4.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building the CertificateGenerator tool using VS 2022 Developer Command Prompt requires to install .NET 4.5 SDK/Targeting Pack manually, I thought it would be nice to upgrade the runtime version and build the tool directly. This is what I get when using .NET 4.5:
Error MSB3644: The reference assemblies for .NETFramework,Version=v4.5 were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

@mconnew
Copy link
Member

mconnew commented Oct 24, 2022

We shouldn't hard code in an internal domain name here. This should have no value and be commented out

Refers to: src/System.Private.ServiceModel/tools/scripts/SetClientEnv-Linux.sh:16 in 5954336. [](commit_id = 5954336, deletion_comment = False)

@mconnew
Copy link
Member

mconnew commented Oct 24, 2022

Can you provide details how to run this if I checkout your branch? We should have some documentation explaining how to use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mconnew mconnew mconnew left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@afifi-ins @dnfadmin @mconnew