Fix Bundling of Install Scripts #2339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added when nobody knew how to debug the codebase and I was new. This should not be here.
It seems its not being bundled into the extension install scripts folder as a backup which should be fixed. As to why the download is failing is another interesting point.
The old CDN returned an empty file
the expectatoin is not in the utils folder, idk why its in there. make sure this does not impact the vsix behavior for sudo but that will be caught in vendor testing.
This reverts commit 471cdbe.
…son/vscode-dotnet-runtime into nagilson-script-path-issue
Member
Author
|
One of my concerns with this pr was the change from the /utils/ folder. The web-pack vsix vs the build version bundles files differently and I was worried that the file bundle would break the other files in the scripts folder. Thankfully it seems that was not the case, which makes sense because then the other components besides the backup install script would be broken. |
MiYanni
approved these changes
Jul 16, 2025
vscode-dotnet-runtime-library/src/Acquisition/InstallScriptAcquisitionWorker.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The .NET Install Scripts are not bundled correctly into the extension anymore. It looks like this is a relic of the CDN changes and the url endpoints no longer work. This is reflected in lower success rates across the telemetry. We should fix that and clean up the related code.
The script is bundled at build time based on the latest version. The script is only used if the online version cannot be reached. This is an existing behavior. Please contact me internally for any other concerns w.r.t this.