Skip to content

Update Dependencies, Migrate to Node 22 #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 9, 2025
Merged

Update Dependencies, Migrate to Node 22 #2317

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
587a60d
Update Dependencies, Migrate to Node 22
nagilson Jun 23, 2025
80d6e69
Bump version and changelog
nagilson Jun 23, 2025
a68dae6
Upgrade testing library
nagilson Jun 23, 2025
9854c49
Migrate lint to linux
nagilson Jun 23, 2025
3d0d245
update pr pipeline as well
nagilson Jun 23, 2025
236838a
switch lint to windows
nagilson Jul 1, 2025
f144cb3
switch build to win
nagilson Jul 1, 2025
fa47b80
Update changelog to reflect new plans
nagilson Jul 1, 2025
0d99f2f
Fix whitespace
nagilson Jul 1, 2025
8761d6f
Test to see if the object type schema can apply in both
nagilson Jul 2, 2025
ba57f1d
temp remove mac os for syntax
nagilson Jul 2, 2025
a0692b4
migrate all pools
nagilson Jul 2, 2025
68f4a38
Specify the pool name further
nagilson Jul 2, 2025
30cbb9a
Switch Build Image on Linux
nagilson Jul 2, 2025
d8da0f1
Try to conditionally use demands vs vmImage
nagilson Jul 2, 2025
1f1ee93
use azure pipelines on macos
nagilson Jul 3, 2025
caaf139
Use ubuntu in 1es
nagilson Jul 3, 2025
bc93909
try the open one
nagilson Jul 3, 2025
31b57ce
try build.
nagilson Jul 3, 2025
3ab2dba
see if 2004 has the right lib
nagilson Jul 3, 2025
2db5a43
fix distro test
nagilson Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 1es-azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ parameters:
os: windows
emoji: 🪟
- name: NetCore1ESPool-Internal
image: 1es-ubuntu-2204
image: ubuntu-latest
Copy link
Member

@MiYanni MiYanni Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the only images available to that agent pool:
image

ubuntu-latest isn't a valid image name.

Copy link
Member Author

@nagilson nagilson Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like name did not get propagated to the pool object which caused the default pool provider of azure pipelines to be used, so this was a valid image name, but it should not have been using that pool provider. I think this has been fixed now.

Copy link
Member Author

@nagilson nagilson Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the doc link to the images. I wish that it was better explained which section is for which pool, since there is no section for the netcore public pool, only the external test pooling in general 🤔

os: linux
emoji: 🐧
- name: Azure Pipelines
Expand Down Expand Up @@ -95,8 +95,8 @@ extends:
parameters:
pool:
name: Azure Pipelines
image: macOS-latest
os: macOS
image: windows-latest
os: windows
Copy link
Member

@MiYanni MiYanni Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, absolutely, should not be done. We should never use external Windows images. We use external macOS images because we don't have internal macOS agents.

Copy link
Member Author

@nagilson nagilson Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is further logic that was already utilizing this, I don't recall how/why that is the case. I looked at the 1es migration PR and some of it may have been a migration tooling issue/pre-existing issue, and some of it may be due to the fact that name was not passed to the parameter pool object, thus causing the azure pipelines pool to be used. I think I've fixed all of those now, good call

useOneEngineeringPool: true
- template: pipeline-templates/package-vsix.yaml@self
parameters:
Expand Down
4 changes: 2 additions & 2 deletions 1pr-azure-pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ stages:
- template: pipeline-templates/lint.yaml
parameters:
pool:
vmImage: macOS-latest
os: macOS
vmImage: windows-latest
os: windows
useOneEngineeringPool: false
- template: pipeline-templates/package-vsix.yaml
parameters:
Expand Down
Loading
Loading