Check dotnet path without which or where first #2234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Which and where can be slow to find. For the common case which we want to make fast, we can just check 'dotnet' first and see if that works. Note: Ideally, this function would only return a string, but that would require writing a wrapper around this return type just for this function and does not follow the other existing patterns. With respect to tests: This should be covered by the existing 'find path' tests.
vscode-dotnet-runtime-library/src/Acquisition/DotnetPathFinder.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
nagilson
commented
Apr 14, 2025
| { | ||
| const oldLookup = process.env.DOTNET_MULTILEVEL_LOOKUP; | ||
| try { | ||
| process.env.DOTNET_MULTILEVEL_LOOKUP = '0'; // make it so --list-runtimes only finds the runtimes on that path: https://learn.microsoft.com/en-us/dotnet/core/compatibility/deployment/7.0/multilevel-lookup#reason-for-change |
Member
Author
There was a problem hiding this comment.
Not enabling this will prevent discovery of dotnet subdirectories:
When running the application through [dotnet](https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet), subdirectories relative to the dotnet executable.
https://learn.microsoft.com/en-us/dotnet/core/compatibility/deployment/7.0/multilevel-lookup
adrianvmsft
approved these changes
Apr 14, 2025
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which and where can be slow to find. For the common case which we want to make fast, we can just check 'dotnet' first and see if that works.
Note: Ideally, this function would only return a string, but that would require writing a wrapper around this return type just for this function and does not follow the other existing patterns.
With respect to tests: This should be covered by the existing 'find path' tests.
cc @lifengl