-
Notifications
You must be signed in to change notification settings - Fork 378
Add new API dotnet.findPath to find the .NET host to use if one already exists that meets a requirement.
#1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
d028fd6
update PATH setting description to make it more clear
nagilson b3bf76d
add very prototype code
nagilson f8fa947
add tests and get runtime check working
nagilson 14f2930
Merge branch 'main' into nagilson-PATH-setting
nagilson 63f943d
Fix some bugs
nagilson 2e890ee
Merge branch 'nagilson-PATH-setting' of https://github.com/nagilson/v…
nagilson ccaf4fe
Consider that the .NET SDK can also satisfy the Runtime
nagilson baaf910
fix typo
nagilson 5ad07f3
fix the tests
nagilson 1ad0921
fix
nagilson 4e1b2c6
fix another test
nagilson e3c23a7
Fix tests even more
nagilson c66895b
undo yarn changes
nagilson 61911be
fix the final test hopefully
nagilson 78fa558
undo yarn changes
nagilson 058f209
Dont use dotnet.exe as its not platform agnostic
nagilson 0989525
use "markdownDescription" for nicer rendering in VSCode
baronfel 81aa6a0
Tweak call to action to use VSCode mechanisms first, then our standar…
baronfel f119def
Fix URLs
baronfel efc75a5
Move to version 2.1.7
nagilson b43b737
add basic command'
nagilson a88e0e2
Ignore existingPath setting for SDK installs.
nagilson a16491a
Remove warning setting and fix invalid path setting
nagilson b43a96a
Fix test
nagilson 57f52ce
Merge remote-tracking branch 'upstream/main' into nagilson-PATH-setting
nagilson 3c385b1
Merge branch 'nagilson-PATH-setting' into nagilson-PATH-api
nagilson 2918dfe
Refactor code out into a Validator for Conditions
nagilson ac7fa96
Prepare code to validate the path
nagilson f18bca3
Merge remote-tracking branch 'upstream/main' into nagilson-PATH-api
nagilson 1e7958a
add a lot of prototypey code
nagilson 9376b6d
add comment for future work
nagilson 59c6dc3
merge with main
nagilson 22a8eca
look up the architecture
nagilson 0b9d6bc
Improve the code
nagilson ae1b06b
Go 2 Directories Up to find the True Path on PATH
nagilson 7d4ed97
Merge remote-tracking branch 'upstream/main' into nagilson-PATH-api
nagilson 3755f24
Final initial loop of API code
nagilson 236b667
Fix bug parsing list runtimes
nagilson 1b7dd99
Add tests
nagilson 99387e3
Fix test and search for where if its not installed
nagilson a91f6f3
Consider where may return multiple values
nagilson 0902d6d
Fix test
nagilson 42b03ee
tests mostly working
nagilson 1a5b9f0
code cleanup - get rid of extra api to set env
nagilson c502c6b
Restore the env var so we dont edit it for other processes
nagilson 3428c75
Uncomment the remaining tests
nagilson baf5760
Respond to lint
nagilson 2801e1b
fix callback
nagilson 76a553d
Fix path to be os-gnostic
nagilson 24cf0e2
Only search for where on windows and also search for which
nagilson 9386062
provide env to the find command so /usr/bin/whcih can be used
nagilson 9b803ef
Call which which instead of which so the correct command can be found
nagilson f34c963
Install 3.1 instead of 7.0 because the DTL CI machines seem to have a…
nagilson 4289ff9
give up on arch check for now because it is inaccurate, see comment
nagilson 183d0de
Add github issue in comment for context
nagilson 1aee50e
make linter happy
nagilson 3ea71a7
Respond to PR feedback
nagilson 17ef50e
Migrate to connection strings
nagilson 31c0d5a
Respond to PR Feedback
nagilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.