Update roslyn to 5.12.0-1.26455.3 - #9734
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The 2.152.x changelog now contains two “Update Roslyn to …” entries, making the shipped Roslyn version and associated sub-bullets ambiguous.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the VS Code C# extension’s pinned Roslyn component version to 5.12.0-1.26455.3, and records the update in the changelog for the current prerelease line.
Changes:
- Bump the default Roslyn version in
package.jsonto5.12.0-1.26455.3. - Add a corresponding entry in
CHANGELOG.mdunder2.152.x.
File summaries
| File | Description |
|---|---|
| package.json | Updates the extension’s default Roslyn version to 5.12.0-1.26455.3. |
| CHANGELOG.md | Adds a 2.152.x changelog entry for the Roslyn bump (currently duplicated with the prior Roslyn update entry). |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
Looks like changes here were all compiler, plus the templates repo move, so change log is non-existent. |
There was a problem hiding this comment.
🟢 Approval recommended
The change is a straightforward, internally consistent Roslyn version bump with a corresponding changelog update and no remaining references to the prior version.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
Dependency bumps to Roslyn can have broad runtime/behavioral impact that isn’t fully verifiable from the diff alone without end-to-end validation signals.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Lite
|
@jjonescz @RikkiGibson Please check the last commit, it makes the linux tests pass, but I'm not sure if this is hiding a bug in file based apps that you might want to know about. |
View Complete Diff of Changes
Option Strict On) (PR: #85124)(PR: #83)