Skip to content

Update roslyn to 5.12.0-1.26455.3 - #9734

Open
davidwengier wants to merge 4 commits into
dotnet:mainfrom
davidwengier:update/roslyn-5-12-0-1-26455-3
Open

Update roslyn to 5.12.0-1.26455.3#9734
davidwengier wants to merge 4 commits into
dotnet:mainfrom
davidwengier:update/roslyn-5-12-0-1-26455-3

Conversation

@davidwengier

Copy link
Copy Markdown
Member

View Complete Diff of Changes

  • Import EditorConfig templates from dotnet/templates (PR: #85157)
  • Improve parser recovery for misplaced 'partial' modifiers (PR: #83216)
  • Add instructions for how to build with analyzers (PR: #83228)
  • Make VB SDK samples strict (Option Strict On) (PR: #85124)
  • Sync FBA sources (PR: #85065)
  • Record partial lambda parsing baselines (PR: #85166)
  • Visit left operand conversion in a fast path of nullable analysis (PR: #85115)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 8742256 (PR: #799)
  • Fix EditorConfig at solution level (PR: #782)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 6347393 (PR: #678)
  • enable nullable (PR: #692)
  • Fix a NullReferenceException in the DeclarePublicAPI analyzer (PR: #677)
  • Merge pull request Have a keyboard shortcut for the yellow bulb options (help) #644 from jmarolf/features/update-default-editorconfig-settings (PR: #644)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 4901452 (PR: #511)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 4901402 (PR: #510)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 4900535 (PR: #509)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 4905189 (PR: #512)
  • Set VSSDKTargetPlatformRegRootSuffix (PR: #461)
  • Update VS SDK (PR: #487)
  • Update VSSDK (PR: #479)
  • Localized file check-in by OneLocBuild Task: Build definition ID 10077: Build ID 4718492 (PR: #478)
  • Fix Editor config issues (PR: #206)
  • fix EditorConfig templates names (PR: #193)
  • Fix vs dev (PR: #134)
  • Add new classlib templates (PR: #132)
  • do not build tasks and use nuget package instead (PR: #92)
  • move-to-arcade (PR: #90)
  • Correcting two option names
    (PR: #83)
  • Trim trailing whitespace in EditorConfig item templates (PR: #73)
  • Update editorconfig default name (PR: #65)
  • Fix access to resources (PR: #64)
  • LOC CHECKIN | dotnet/templates master | 20180629 (PR: #61)
  • adding VB editorconfig templates (PR: #56)
  • Merge dev15.8 preview2 to master (PR: #55)
  • fix setup (PR: #54)
  • Merges/dev15.8 preview2 to master (PR: #52)
  • Update setup authoring (PR: #50)
  • Merges/dev15.7.x to dev15.8 preview2 (PR: #48)
  • reset to defaults (PR: #47)
  • Fix aspnet node order (PR: #46)
  • Merges/dev15.8 preview2 to master (PR: #45)
  • Refactor (PR: #44)
  • update vb authoring (PR: #41)
  • adding localized resources (PR: #40)
  • fixing Kaseys comments (PR: #39)
  • Editorconifg changes (PR: #38)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 6, 2026 22:34
@davidwengier
davidwengier requested a review from a team as a code owner September 6, 2026 22:34
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The 2.152.x changelog now contains two “Update Roslyn to …” entries, making the shipped Roslyn version and associated sub-bullets ambiguous.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates the VS Code C# extension’s pinned Roslyn component version to 5.12.0-1.26455.3, and records the update in the changelog for the current prerelease line.

Changes:

  • Bump the default Roslyn version in package.json to 5.12.0-1.26455.3.
  • Add a corresponding entry in CHANGELOG.md under 2.152.x.
File summaries
File Description
package.json Updates the extension’s default Roslyn version to 5.12.0-1.26455.3.
CHANGELOG.md Adds a 2.152.x changelog entry for the Roslyn bump (currently duplicated with the prior Roslyn update entry).
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CHANGELOG.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 6, 2026 22:54
@davidwengier

Copy link
Copy Markdown
Member Author

Looks like changes here were all compiler, plus the templates repo move, so change log is non-existent.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a straightforward, internally consistent Roslyn version bump with a corresponding changelog update and no remaining references to the prior version.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Copilot AI review requested due to automatic review settings September 7, 2026 03:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Dependency bumps to Roslyn can have broad runtime/behavioral impact that isn’t fully verifiable from the diff alone without end-to-end validation signals.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

@davidwengier

Copy link
Copy Markdown
Member Author

@jjonescz @RikkiGibson Please check the last commit, it makes the linux tests pass, but I'm not sure if this is hiding a bug in file based apps that you might want to know about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants