Configurable project list cap #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "omnisharp.maxProjectResults": { | ||
| "type": "number", | ||
| "default": 100, |
There was a problem hiding this comment.
Should we increase this number as part of this change?
There was a problem hiding this comment.
we could, perhaps 250? Thing is you probably want to cap it at a reasonable number cause when you open against i.e. c:\ it would take ages to scan if the limit is too high
DustinCampbell
approved these changes
Nov 15, 2016
| "omnisharp.maxProjectResults": { | ||
| "type": "number", | ||
| "default": 250, | ||
| "description": "The amount of projects to be shown in the 'Select Project' dropdown, discovered in the descendant folders of the working folder. Once the limit is reached, the extension will stop searching for projects." |
There was a problem hiding this comment.
This should read: "The maximum number of projects to be shown in the 'Select Project' dropdown (maximum 250)"
|
Thanks - done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875
Introduces a new setting
omnisharp.maxProjectResultswith a default value of100in place of the old hardcoded100. User can now set the value to whatever seems fit for their workflow.Naturally, larger value i.e.
5000would mean longer start up time.