Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #735 - "Running" forever for folder with multiple .NET Core projects #754

Merged
merged 2 commits into from
Sep 13, 2016

Conversation

eamodio
Copy link
Contributor

@eamodio eamodio commented Sep 10, 2016

No description provided.

@dnfclas
Copy link

dnfclas commented Sep 10, 2016

Hi @eamodio, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@dnfclas
Copy link

dnfclas commented Sep 10, 2016

@eamodio, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@eamodio
Copy link
Contributor Author

eamodio commented Sep 10, 2016

Damn -- sorry about the trailing whitespace changes :(

@DustinCampbell
Copy link
Member

We're not actually using typings.json yet (we will in the future). I'd kind of prefer that we either don't use it, or convert all of our existing typings to use it.

@DustinCampbell
Copy link
Member

fixing trailing whitespace is fine. 😄

@eamodio
Copy link
Contributor Author

eamodio commented Sep 12, 2016

@DustinCampbell I'm happy to do either (convert all or nuke it) -- do you have a preference? And if it is to convert everything -- should I do that as a separate PR?

@eamodio
Copy link
Contributor Author

eamodio commented Sep 12, 2016

@DustinCampbell Since TypeScript 2 is moving away from Typings (in favor or npm maybe it is best to leave it alone and I'll just remove the typings stuff. Sound good?

@DustinCampbell
Copy link
Member

Works for me @eamodio. I'm still digging into TypeScript 2 (excited for tagged unions!) and hadn't dug into the typings changes yet.

…re projects

Also stops multiple duplicate requests from hitting server within a short window
@eamodio
Copy link
Contributor Author

eamodio commented Sep 13, 2016

@DustinCampbell should be all set now -- remove the typings stuff

@DustinCampbell
Copy link
Member

LGTM

@DustinCampbell DustinCampbell merged commit fbbf5a1 into dotnet:master Sep 13, 2016
@DustinCampbell DustinCampbell added this to the 1.5 milestone Sep 13, 2016
@eamodio eamodio deleted the bug-#735 branch September 14, 2016 05:28
@DustinCampbell
Copy link
Member

Note: lodash adds 1.3 MB to node_modules, and around 0.7 MB to the packaged VSIX. 😞

@eamodio
Copy link
Contributor Author

eamodio commented Sep 19, 2016

@DustinCampbell :( I could just add the lodash debounce module rather than all of lodash -- that should cut a lot out.

@DustinCampbell
Copy link
Member

I just noticed it when building the 1.5-beta1. The difference between the 1.4.1 and 1.5-beta1 releases in size is pretty much all lodash. Crazy!

@DustinCampbell
Copy link
Member

I think it's worth just adding the essential module. The size difference translates to the end user experience because it'll take more time for extension to download and install in VS Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants