-
Notifications
You must be signed in to change notification settings - Fork 678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #735 - "Running" forever for folder with multiple .NET Core projects #754
Conversation
Hi @eamodio, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
@eamodio, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Damn -- sorry about the trailing whitespace changes :( |
We're not actually using typings.json yet (we will in the future). I'd kind of prefer that we either don't use it, or convert all of our existing typings to use it. |
fixing trailing whitespace is fine. 😄 |
@DustinCampbell I'm happy to do either (convert all or nuke it) -- do you have a preference? And if it is to convert everything -- should I do that as a separate PR? |
@DustinCampbell Since TypeScript 2 is moving away from Typings (in favor or npm maybe it is best to leave it alone and I'll just remove the typings stuff. Sound good? |
Works for me @eamodio. I'm still digging into TypeScript 2 (excited for tagged unions!) and hadn't dug into the typings changes yet. |
…re projects Also stops multiple duplicate requests from hitting server within a short window
@DustinCampbell should be all set now -- remove the typings stuff |
LGTM |
Note: lodash adds 1.3 MB to node_modules, and around 0.7 MB to the packaged VSIX. 😞 |
@DustinCampbell :( I could just add the lodash debounce module rather than all of lodash -- that should cut a lot out. |
I just noticed it when building the 1.5-beta1. The difference between the 1.4.1 and 1.5-beta1 releases in size is pretty much all lodash. Crazy! |
I think it's worth just adding the essential module. The size difference translates to the end user experience because it'll take more time for extension to download and install in VS Code. |
No description provided.