Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting for field, variable and new expression types #716

Closed
wants to merge 2 commits into from

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Aug 26, 2016

Effectively the result is this:

image

and in fact matches the TypeScript highlighting:

image

Thoughts?

Closes #687
Relates to #674

Before

image

After

image

@ivanz ivanz force-pushed the feature-colour-variables branch from ad139ec to dddf6f5 Compare August 26, 2016 11:45
@ivanz
Copy link
Contributor Author

ivanz commented Aug 26, 2016

I think the blue makes it a bit too colourful actually. Here is a screenshot with the variable/field name highlighting disabled (it's still enabled in the code of this pull request). I think I am personally leaning to remove the variable name blue colour, because it's only highlighting the definition of the variable and not the usages, so it looks a bit weird?

image

@ivanz ivanz closed this Aug 26, 2016
@ivanz
Copy link
Contributor Author

ivanz commented Aug 26, 2016

Closing this, because it hit me that I am not fully happy with this and that it makes the code less readable without the semantic bit to be able to highlight types and variable usages as well. 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants