Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight body of C# 6 expression bodied members properly. #681

Merged
merged 1 commit into from
Aug 18, 2016

Conversation

ivanz
Copy link
Contributor

@ivanz ivanz commented Aug 18, 2016

Fixes #638, #403, #679, #249

Before

image

After

image

@DustinCampbell
Copy link
Member

LGTM

@DustinCampbell DustinCampbell added this to the 1.4 milestone Aug 18, 2016
@DustinCampbell
Copy link
Member

I wish we didn't have to copy paste so much though.

@DustinCampbell DustinCampbell merged commit 5eeab7c into dotnet:master Aug 18, 2016
@ivanz
Copy link
Contributor Author

ivanz commented Aug 18, 2016

@DustinCampbell I wish we had a way to write tests for this this and avoid regressions in the future ;)

@DustinCampbell
Copy link
Member

yeah, I want to figure that out too.

@ivanz ivanz deleted the highlight-expression-bodies branch August 26, 2016 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants