Support for viewing type information for types not in the source #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using type metadata. Fixes dotnet#165
|
I have updated the pull request with support for Peek definition :) |
|
I am not sure why is it saying "cla-required" - I have already signed it and you can see that in my other pull requests it says it's not needed? I am happy to do the CLA again though if that's what's needed? |
|
CLA retry |
This was referenced Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for viewing type information for types not in the source by using existing functionality in omnisharp server. Closes #165 .
Potential improvements:
Doesn't currently support "peek definition" properly - it behaves as if it's a "go to definition" action. This is caused, because I create a "temporary" document provider and manually open a document pre-filling it with content rather than simply returning a location from the command.Go To Definition
Peek Definition