Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update razor to 7.0.0-preview.23528.1 #6607

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Update razor to 7.0.0-preview.23528.1 #6607

merged 3 commits into from
Oct 30, 2023

Conversation

ryzngard
Copy link
Contributor

No description provided.

@ryzngard ryzngard requested review from davidwengier, allisonchou and a team October 29, 2023 22:45
@ryzngard ryzngard marked this pull request as ready for review October 30, 2023 01:27
@ryzngard ryzngard requested a review from a team as a code owner October 30, 2023 01:27
@ryzngard ryzngard changed the title Attempt to update razor to 7.0.0-preview.23528.1 Update razor to 7.0.0-preview.23528.1 Oct 30, 2023
@ryzngard ryzngard merged commit f7c13f0 into dotnet:main Oct 30, 2023
9 checks passed
@ryzngard ryzngard deleted the bump_razor branch October 30, 2023 02:18
@davidwengier
Copy link
Contributor

I'm surprised and a little scared that this didn't fail the razor integration tests, at least, as I completely forgot that we needed a Roslyn bump too. In theory this is now producing project.razor.vscode.bin version 2, but wanting to read version 3. Unless I did something wrong in my PR 🤷‍♂️

@ryzngard
Copy link
Contributor Author

I'm surprised and a little scared that this didn't fail the razor integration tests, at least, as I completely forgot that we needed a Roslyn bump too. In theory this is now producing project.razor.vscode.bin version 2, but wanting to read version 3. Unless I did something wrong in my PR 🤷‍♂️

I thought as long as we went in first it was okay? Let me manually check...

@davidwengier
Copy link
Contributor

On my machine, manual testing definitely fails. I expect if (when!) we had semantic tokens integration tests they would have failed.

Now that I think more about it, it's actually not surprising that formatting tests don't fail, as we don't generally delegate to Roslyn to format, we just use the Roslyn public API directly.

@davidwengier davidwengier mentioned this pull request Oct 30, 2023
Merged
@davidwengier
Copy link
Contributor

Opened #6608 to fix. Tag helper discovery is broken with just this PR, but that one fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

@allisonchou allisonchou Awaiting requested review from allisonchou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryzngard @davidwengier