Add support for nuget restore commands #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmalinowski
approved these changes
Nov 2, 2023
| ): Promise<void> { | ||
| const projects = await languageServer.sendRequest0( | ||
| RestorableProjects.type, | ||
| new vscode.CancellationTokenSource().token |
There was a problem hiding this comment.
Is there not a better cancellation token to use for a command, or some UI that can be created for this? I don't think it's important to, as much as I am wondering out loud what the expected pattern is for things like this.
There was a problem hiding this comment.
We could put a progress bar on this and use cancellation there. But it didn't seem necessary in this case - the request barely does anything and immediately shows a quick pick when its done.
There was a problem hiding this comment.
Yeah a progress bar does seem overkill. I wasn't sure if there was a simple pattern for commands with async work that's commonly used.
There was a problem hiding this comment.
I don't know of a different one :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side PR - dotnet/roslyn#70588